fix: return proper HTTP status codes for delete/undelete errors #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The delete and undelete handlers for skills and souls were catching all errors and returning 401 Unauthorized, even for errors like: - 'Skill not found' (should be 404) - 'Forbidden' (should be 403) - Other validation errors (should be 400) This change updates the error handling to return appropriate status codes: - 401 Unauthorized: authentication failures - 403 Forbidden: authorization failures (not owner/admin/moderator) - 404 Not Found: skill/soul/user not found - 400 Bad Request: other errors with descriptive message Fixes clawdbot#34
Contributor
|
@sergical is attempting to deploy a commit to the Amantus Machina Team on Vercel. A member of the Team first needs to authorize it. |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Additional Suggestion:
The cliSkillDeleteHandler in httpApi.ts catches all errors and only distinguishes "Unauthorized", returning 400 for all other errors including "Forbidden" (should be 403) and "Skill not found"/"User not found" (should be 404).
When AbortController.abort() receives a string instead of an Error, the string itself is thrown. pRetry then wraps it in a confusing message: 'Non-error was thrown: Timeout' Changed all 3 occurrences in http.ts: - apiRequest (line 57) - apiRequestForm (line 106) - downloadZip (line 141) Now timeouts will surface as proper Error objects with clear messages.
|
you might wanna rebase on #37 - it fixed the timeout errors across for me (also appreciate a pair of eyes on it to confirm it looks reasonable 🙏) |
Verifies that deleting a non-existent skill returns a proper 'not found' error instead of a generic 'Unauthorized' message.
sergical
force-pushed
the
fix/delete-error-handling
branch
from
5d95c44 to
1ae0498
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
clawdhub delete <slug>command returns confusing error messages. Two issues were found:Issue 1: API returns 401 for all errors
The delete/undelete handlers catch ALL errors and return
Unauthorized, masking real issues likeSkill not foundorForbidden.Issue 2: CLI timeout throws strings instead of Errors
When requests timeout,
controller.abort('Timeout')passes a string. This causes pRetry to throw:Reproduction
Fixes
1. API Error Handling (convex/httpApiV1.ts)
Updated error handling in 4 handlers to return appropriate HTTP status codes:
skillsDeleteRouterV1HandlerskillsPostRouterV1Handler(undelete)soulsDeleteRouterV1HandlersoulsPostRouterV1Handler(undelete)Before: All errors → 401 Unauthorized
After:
2. CLI Timeout Handling (packages/clawdhub/src/http.ts)
Fixed 3 occurrences of
controller.abort('Timeout')to use proper Error objects:apiRequest(line 57)apiRequestForm(line 106)downloadZip(line 141)Before:
controller.abort('Timeout')— throws stringAfter:
controller.abort(new Error('Timeout'))— throws ErrorFixes #34