Prevent duplicate messages when using addToolApprovalResponse #28068
+110
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lResponse This syncs documentation for cloudflare/agents PR #829, which fixes duplicate assistant messages when using addToolApprovalResponse with tools that have needsApproval. Changes: - Add addToolApprovalResponse to useAgentChat API reference - Document tool approval handling with example - Update human-in-the-loop guide to explain the fix - Add changelog entry for the bug fix Related to: cloudflare/agents#829
agents-git-bot
bot
requested review from
a team,
elithrar,
irvinebroque,
rita3ko,
thomasgauvin,
threepointone and
whoiskatrin
as code owners
github-actions
bot
added
product:changelog
product:agents
github-actions
bot
assigned
elithrar,
irvinebroque,
rita3ko,
thomasgauvin,
threepointone and
whoiskatrin
Contributor
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Documentation sync for cloudflare/agents PR #829
Fixes duplicate assistant messages when using
addToolApprovalResponsewith tools that haveneedsApproval.Problem
When a user approves a tool via
addToolApprovalResponseand then callssendMessage, two assistant messages were persisted with the samecontentbut different IDs:msg_...) stuck inpendingstatecompletedstateSolution
Wrap
addToolApprovalResponsein server notification to update the message in place using the existing ID, preventing duplicates whensendMessageis called.Changes
addToolApprovalResponsedocumentationRelated
needsApprovaltools agents#790Automated documentation sync for cloudflare/agents#829