Default useragent #134
Open
Default useragent #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruifigueira
reviewed
Aug 7, 2025
ruifigueira
reviewed
Aug 7, 2025
| return await this.#defaultContext.newPage(); | ||
| const page = await this.#defaultContext.newPage(); | ||
| await page.setUserAgent( | ||
| 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/119.0.0.0 Safari/537.36' |
Collaborator
There was a problem hiding this comment.
I think we also need to do the same thing in BrowserContext. I think that both Browser.newPage and BrowserContext.newPage end up calling https://github.com/cloudflare/puppeteer/blob/19e40c556e10b8d259df11f0dc32ea4f1a495789/packages/puppeteer-core/src/cdp/Browser.ts#L346C1-L347C1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Avoids a situation where user-agend is empty
Did you add tests for your changes?
✔️
If relevant, did you update the documentation?
Not relevant - no API changes
Summary
The cloud browser does not set a default user agent
Does this PR introduce a breaking change?
Not to my knowledge