add opennextjs streaming tests #5993
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicb
reviewed
Feb 1, 2026
vicb
reviewed
Feb 1, 2026
vicb
reviewed
Feb 1, 2026
danlapid
reviewed
Feb 1, 2026
vicb
reviewed
Feb 1, 2026
danlapid
reviewed
Feb 1, 2026
vicb
reviewed
Feb 1, 2026
vicb
reviewed
Feb 1, 2026
Contributor
vicb
left a comment
vicb
left a comment
There was a problem hiding this comment.
src/workerd/api/tests/opennextjs/README.md is gigantic :(
One way to simplify would be to use the migrate command created by @dario-piotrowicz recently.
Maybe something simpler would be to add an exemple in the ON repo and use that? I doubt the readme would be maintained here?
jasnell
reviewed
Feb 2, 2026
Collaborator
|
186k+ lines are nearly impossible to adequately review. Is there a way to have much of this automated / generated dynamically by bazel at build time to cut down on the static file size, particular in the worker file? |
anonrig
force-pushed
the
yagiz/add-opennextjs-test
branch
from
22d3139 to
662ba49
Compare
anonrig
force-pushed
the
yagiz/add-opennextjs-test
branch
from
662ba49 to
560b53d
Compare
Member
Author
|
@jasnell I've force-pushed and address all concerns. The changes are much more readable/reviewable now. |
anonrig
force-pushed
the
yagiz/add-opennextjs-test
branch
2 times, most recently
from
5bb0f71 to
3eb83e4
Compare
anonrig
force-pushed
the
yagiz/add-opennextjs-test
branch
from
3eb83e4 to
3e0019f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Task: EW-10513
Added a task with the help of AI to write some tests using a real opennextjs bundle. Added a REAADME for generating them later on. PS: I've trimmed as much as I can from the output that isn't important to us (in this context).