add a compat enabled date for fetchIterableTypeSupport #6006
+9
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The generated output of |
vicb
force-pushed
the
vicb/fetchIterableTypeSupport
branch
from
3928134 to
08e9953
Compare
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
Footnotes
|
jasnell
reviewed
Feb 3, 2026
| $compatEnableFlag("fetch_iterable_type_support") | ||
| $compatDisableFlag("no_fetch_iterable_type_support"); | ||
| $compatDisableFlag("no_fetch_iterable_type_support") | ||
| $compatEnableDate("2026-02-12"); |
Collaborator
There was a problem hiding this comment.
Since releases are moving slightly slower these days, I'd feel a bit safer pushing this out another week.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
fetchIterableTypeSupportenabled by default from 2026-02-12.Note that
fetchIterableTypeSupportOverrideAdjustmentwill also be enabled by default from that date because it hasworkerd/src/workerd/io/compatibility-date.capnp
Line 1262 in a89ad60
Some more details about this PR:
When we tried to enable the native
node:processv2, we ran into issue because it caused astro to detect theworkerdruntime as if it was Node and triggering a known issue in the code path it would then take.Our plan is to make sure both
fetchIterableTypeSupportandfetchIterableTypeSupportOverrideAdjustmentare enabled before enablingnode:process.This is detailed in this workers-sdk issue. Please read it, ask questions, and give feedback.
/cc @danlapid @jasnell @guybedford