-
Notifications
You must be signed in to change notification settings - Fork 864
OT Cartridges - Light(?) Ordnance Overhaul #11662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MPhonks
wants to merge
27
commits into
cmss13-devs:master
Choose a base branch
from
MPhonks:ot-cartridges
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o ot-cartridges
|
OT's eating good with this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Code Improvement
Make the code longer
Feature
Feature coder badge
Fix
Fix one bug, make ten more
size/L
Denotes a PR that changes 200-799 lines, ignoring generated files.
Sprites
Remove the soul from the game.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This pull requests adds OT Cartridges, an additional way of giving explosive casings exciting (and particularly underused) effects. Found in the Armylathe, currently three flavors of cartridges can be vended: Smoke, Flash, and Shrapnel. They all require a plasteel sheet to create, and each have a defined use and chemical content, allowing for greater experimentation in the workshop.
Armylathe
Cartridges
Ordnance Cartridges have some special properties:
Leftover Flash
(Might need a better sprite...)

Other changes include:
OT Cartridges were tested with the simulator and appear to have worked fine. I haven't tested every combination of every cartridge and every casing, but they should all work to some degree as intended.
On another note: this is my first "real" project, only having dabbled in Dream Maker here and there before. I am not actually that good at coding or spriting and I might have overlooked some very important things, so feedback is very much appreciated!
Explain why it's good for the game
There are many underused reactions in the game that Ordnance Technician drool over, but can never use. The limit on reagent volume makes chemical smoke very hard to utilize in experimental ordnance, and the flash powder reaction is a very interesting mechanic that has turned out to be broken since... who even knows when?
Shrapnel Cartridges are a bit of a doozy. They are a direct upgrade for many casings, but shrapnel overall is at the same time seldom seen in rounds. With the limit of cartridges allowed for casings, the rather small amount provided, and the extra cost of production, I hope to have balanced things out well enough - but some tuning might be necessary.
This PR aims bring some fresh air into the role in terms of experimentation, as well as introduce a potential framework for selectively adding reagents or effects to ordnance in the future. This PR's goal is NOT to make OT stronger in a very substantial way, but rather more fun to play.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑 MarpleJones
add: ordnance cartridges system, coming in three flavors: smoke, flash, shrapnel
add: smoke cartridges, require sugar to function, and create chemsmoke when detonated in a casing
add: flash cartridges, require aluminum to function, and create flames and when detonated in a casing
add: shrapnel cartridges, do not require anything but an explosion to function, but can be modified with existing modifying reagents when detonated in a casing.
add: armylathe cartridges category, plasteel intake
code: plasteel no longer provide metal, and now only give plasteel to autolathes
code: added cartridge logic to custom explosives, including maximum cartridge counts and reagent code
fix: fixed flash powder, with it being created as an inert chemical upon reaction
/:cl: