python_min continued
#642
python_min continued
#642
Conversation
…ed a new function to enforce minimum Python version dependencies. Signed-off-by: Marcelo Trevisani <[email protected]> Part-of: conda#581
Co-authored-by: Filipe <[email protected]> Part-of: conda#581 Closes: conda#581
Signed-off-by: Michał Górny <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Right now, the main problem is that |
Oh, it's |
Signed-off-by: Michał Górny <[email protected]>
|
@marcelotrevisani, this isn't perfect but I think that's absolutely minimal changes needed to make grayskull produce v0 recipes that pass the linter. I'm going to look into fixing |
Output `{{ python_min }}.*` rather than `{{ python_min }}` in `host` and
`test` dependencies, as conda-recipe-manager inlines the version when
updating the latter to the former. Fixing it requires major
architecture changes (xref conda/conda-recipe-manager#307), so instead
emit the former directly.
While this is not a canonical form for v0 recipes, it is valid
(arguably, even more correct) and satisfies conda-smithy.
Signed-off-by: Michał Górny <[email protected]>
|
Okay, it's 100% ready now. As it turns out, using I've also filed conda/conda-recipe-manager#473 to fix the remaining issues and get fully complaint |
marcelotrevisani
left a comment
marcelotrevisani
left a comment
There was a problem hiding this comment.
LGTM! Thanks again for your contribution! :)
|
Thanks @mgorny, this is very exciting and much appreciated!!!!! |
|
Thanks. This is quite complex, so please don't hesitate to ping me if you notice any regressions. That said, I think that's the last change I needed in grayskull, so if you could consider a new release anytime soon, that'd be helpful. The plan is to add a tutorial using grayskull and v1 recipes to conda-forge docs, and a prerequisite is that the recipes generated pass lint. |
|
@mgorny, it's already been released, and already installable from conda-forge! 🚀 |
3 participants
Description
This is continuation of #581. It's not ready yet but I'm opening the PR for early feedback. I've started with the commits from #581, then added logic to set
python_minJinja var and fix whitespace in{{ ... }}deps. It feels hacky but I think that's the easiest way of achieving it.I still need to fix v1 recipes.
Fixes #574.