fix: #91 : "@modelcontextprotocol/sdk": "^1.17.1" resolves to latest 1.25.1 which depends on zod v4 which has breaking changes. #95
Conversation
…to latest 1.25.1 which depends on zod v4 which has breaking changes.
There was a problem hiding this comment.
Pull request overview
This PR addresses a dependency version issue with @modelcontextprotocol/sdk by pinning it to an exact version. However, it also includes unrelated functional changes that add error and warning arrays to build summaries.
Key Changes:
- Pins
@modelcontextprotocol/sdkto exact version1.17.1(removing the caret^) - Adds
errorsandwarningsarrays (limited to first 10 entries) toextractBuildSummaryreturn value - Enhances build guidance to display warning count in successful builds
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| package.json | Removes caret from @modelcontextprotocol/sdk version to pin to exact 1.17.1 |
| package-lock.json | Updates dependency resolution to 1.17.1 and adds peer dependency flags to dev dependencies |
| src/utils/response-cache.ts | Adds errors and warnings arrays (first 10 entries) to extractBuildSummary return object |
| tests/tests/utils/response-cache.test.ts | Adds comprehensive test coverage for new errors/warnings array fields, including limit test |
| src/tools/xcodebuild/build.ts | Adds warning count indicator to success guidance messages |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| // Include first 10 errors and warnings for immediate visibility | ||
| errors: errors.slice(0, 10).map(e => e.trim()), | ||
| warnings: warnings.slice(0, 10).map(w => w.trim()), |
There was a problem hiding this comment.
This PR introduces new fields (errors and warnings arrays) to the build summary return value. However, the PR title and description only mention fixing the @modelcontextprotocol/sdk version issue. This is an unrelated feature addition that should either:
- Be documented in the PR description to explain why these fields are being added
- Be moved to a separate PR focused on this feature
Additionally, this is a breaking change to the public API of extractBuildSummary (new required fields in the return object) but there's no documentation or discussion about backwards compatibility.
| // Include first 10 errors and warnings for immediate visibility | |
| errors: errors.slice(0, 10).map(e => e.trim()), | |
| warnings: warnings.slice(0, 10).map(w => w.trim()), |
…ssue and produces streaming output. Which caused xc-mcp to not return anything at all. Enhanced xcodebuild output with immediate error/warning visibility and streaming command execution.
1 participant
fix #91 : "@modelcontextprotocol/sdk": "^1.17.1" resolves to latest 1.25.1 which depends on zod v4 which has breaking changes.