Use TypedExternalConnector and remove type assertions #138
+13
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no>
Collaborator
|
Hi @chlunde Thanks for the PR, it looks good to me. Just one comment, would you be able to update the go-template in https://github.com/crossplane/provider-template/tree/main/hack/helpers/controller/KIND_LOWER as well? To be able to generate the same implementation as your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
By using TypedExternalConnector we can simplify the code a bit, and remove some error classes.
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
It compiles, tests are OK. I also did a similar change to provider-sql: crossplane-contrib/provider-sql#284