Support manual glue class registration #3120
Draft
+228
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpkorstanje
commented
Nov 25, 2025
| * @param glueClassNames The classes of glue to be loaded. | ||
| */ | ||
| default void loadGlueClasses(Glue glue, Set<String> glueClassNames) { | ||
| // TODO: Refactor out a request object. |
Contributor
Author
There was a problem hiding this comment.
TODO:
- Refactor out a request object.
mpkorstanje
commented
Nov 25, 2025
|
|
||
| public RuntimeOptionsBuilder addGlueClass(String glueClassName) { | ||
| // TODO: Support Class<?> ? | ||
| parsedGlueClasses.add(glueClassName); |
Contributor
Author
There was a problem hiding this comment.
TODO:
- Also support classes.
How to deal with class loading?
7 tasks
mpkorstanje
force-pushed
the
feature/manual-glue-class-registration
branch
from
b03dd28 to
c3ddc6f
Compare
mpkorstanje
commented
Dec 28, 2025
| } | ||
|
|
||
| @Override | ||
| public Set<String> getGlueClasses() { |
mpkorstanje
commented
Dec 28, 2025
| } | ||
|
|
||
| @Override | ||
| public void loadGlueClasses(Glue glue, Set<String> glueClassNames) { |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
⚡️ What's your motivation?
Closes: #3118
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.