fix: pass naming pattern through to dm_learn_from_db() (#2213)

[owenjonesuob]

Fixes #2213.

I had to move the "smart default" logic for .names up one level, from get_src_tbl_names() into dm_from_con() - but I think that is a better place to keep it anyway, since that's where its behaviour is documented.

I've also made sure names_pattern is used consistently as the "internal" name for this argument, wherever we see this "naming pattern" concept.

[aviator-app]

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This pull request is currently open (not queued).

How to merge

To merge this PR, comment /aviator merge or add the mergequeue label.

---

See the real-time status of this PR on the Aviator webapp.

Use the Aviator Chrome Extension to see the status of your PR within GitHub.

[Copilot]

Pull Request Overview

This PR fixes an issue where the naming pattern was not being passed through to dm_learn_from_db(). The fix involves refactoring the "smart default" logic for naming patterns from get_src_tbl_names() to dm_from_con() and ensuring consistent use of names_pattern as the parameter name throughout the codebase.

Key changes:

• Moved smart default logic for naming patterns from get_src_tbl_names() to dm_from_con()
• Standardized parameter name from names to names_pattern across functions
• Updated dm_learn_from_db() to use the correct column names with dot prefixes for glue templating

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
R/learn.R	Updated dm_learn_from_db() parameter name and column selection to use dot-prefixed names
R/dm_from_con.R	Added smart default logic for naming patterns and updated function calls to use names_pattern
R/db-helpers.R	Removed smart default logic and updated parameter name to names_pattern
tests/testthat/test-db-helpers.R	Updated test calls to use names_pattern parameter instead of names

[Copilot]

The function documentation needs to be updated to reflect the parameter name change from name_format to names_pattern. The @param documentation likely still references the old parameter name.

[krlmlr]

@claude: Fix tests.

[krlmlr]

@copilot: Fix tests.

[krlmlr]

@owenjonesuob: Thank you for your patience.

[claude]

Claude encountered an error —— View job

Failed with exit code 128

---

I'll analyze this and get back to you.