Tests for radiative cooling approximation icooling=9

.github/workflows/coolingra.yml

@@ -0,0 +1,86 @@
+name: coolingra
+
+# Trigger on pull request, but only for these branches
+on:
+  workflow_call:
+
+env:
+  SYSTEM: gfortran
+  OMP_STACKSIZE: 512M
+  OMP_NUM_THREADS: 4
+  PHANTOM_DIR: ${{ github.workspace }}
+  SPLASH_DIR: ${{ github.workspace }}/splash
+
+# A workflow run is made up of one or more jobs that can run sequentially or in parallel
+jobs:
+  coolingra:
+
+    # The type of runner that the job will run on
+    runs-on: ubuntu-latest
+
+    # Steps represent a sequence of tasks that will be executed as part of the job
+    steps:
+    - name: install gfortran compiler
+      uses: fortran-lang/setup-fortran@v1
+      with:
+         compiler: gcc
+
+    - name: Check gfortran version
+      run: gfortran --version
+
+    - name: "Clone phantom"
+      uses: actions/checkout@v4
+
+    - name: "Compile phantom"
+      run: make SETUP=testcoolra phantom
+
+    - name: "Compile phantomsetup"
+      run: make SETUP=testcoolra setup
+
+    - name: "Create test directory and copy binaries"
+      run: |
+        mkdir -p test_coolra
+        cp bin/phantom test_coolra/
+        cp bin/phantomsetup test_coolra/
+        cp data/cooling/sphere.setup test_coolra/
+        cp data/cooling/sphere.in test_coolra/
+        cp data/cooling/Masunaga_2000_collapse.csv test_coolra/
+        cp data/cooling/check_masunaga_vs_maxvals.f90 test_coolra/
+        cd test_coolra
+
+    - name: "Run phantom test"
+      run: |
+       cd test_coolra
+
+        # run the test, run phantomsetup 3 times to ensure .setup file is rewritten if necessary
+        ./phantomsetup sphere.setup
+        ./phantomsetup sphere.setup
+        ./phantomsetup sphere.setup
+        ./phantom sphere.in
+
+    - name: Install splash with apt-get
+      run: |
+       sudo apt-get update
+       sudo apt-get install -y splash
+
+    - name: "Check SPLASH"
+      run: splash --version
+
+    - name: "Run splash maxvals on dump files"
+      run: |
+       cd test_coolra
+       splash calc max sphere_*0 -dev /null
+
+       if [ -f maxvals.out ]; then
+           echo "maxvals.out found"
+       else
+           echo "ERROR: maxvals.out not produced"
+           exit 1
+       fi
+
+    - name: "Compile and run check code"
+      run: |
+       cd test_coolra
+       gfortran -o runcheck.o check_masunaga_vs_maxvals.f90
+       ./runcheck.o
+

.github/workflows/on_pr.yml

@@ -34,12 +34,15 @@ jobs:
     krome:
         uses: ./.github/workflows/krome.yml
 
+    coolingra:
+        uses: ./.github/workflows/coolingra.yml
+
     summary:
 
         # This name matches the branch protection requirement
         name: summary
 
-        needs: [build, test, mpi, mcfost, binary, growth, krome]
+        needs: [build, test, mpi, mcfost, binary, growth, krome, coolingra]
         if: success() || failure() && github.event_name == 'pull_request'
         runs-on: ubuntu-latest
         steps:
@@ -94,4 +97,11 @@ jobs:
               exit 1
             fi
 
+            if [[ "${{ needs.coolingra.result }}" == "success" ]]; then
+              echo "Rad cooling approx jobs succeeded"
+            else
+              echo "At least one rad cooling approx test failed"
+              exit 1
+            fi
+
             echo "All tests succeeded"

.github/workflows/on_push.yml

@@ -29,3 +29,6 @@ jobs:
 
     krome:
         uses: ./.github/workflows/krome.yml
+
+    coolingra:
+        uses: ./.github/workflows/coolingra.yml

build/Makefile

@@ -295,7 +295,6 @@ ifeq ($(INJECT_PARTICLES), yes)
 endif
 
 # do double precision flag last (append only to FFLAGS)
-
 ZZFFLAGS := ${FFLAGS}
 ifeq ($(DOUBLEPRECISION), yes)
     FFLAGS += ${DBLFLAG}
@@ -665,9 +664,9 @@ SRCSPLITPART=utils_indtimesteps.f90 utils_getneighbours.F90 utils_splitmerge.f90
 # 22/4/24: added setup_params to avoid weird build failure with ifort on Mac OS
 SRCTESTS=utils_testsuite.f90 test_kernel.f90 \
          ${SRCAPR} test_apr.f90 test_dust.f90 test_growth.f90 test_smol.F90 \
-         test_nonidealmhd.f90 directsum.f90 test_gravity.f90 \
-         test_derivs.f90 test_cooling.f90 test_eos_stratified.f90 \
-         test_eos.f90 test_externf.f90 test_rwdump.f90 \
+         test_nonidealmhd.F90 directsum.f90 test_gravity.f90 \
+         test_derivs.F90 test_cooling.f90 test_eos_stratified.f90 \
+         test_eos_stam.f90 test_eos.f90 test_externf.f90 test_rwdump.f90 \
          test_step.F90 test_indtstep.f90 ${SRCSETSTAR} utils_filenames.f90 utils_tables.f90 \
          grids_for_setup.f90 set_disc.f90 set_orbit.f90 test_setdisc.F90 test_setstar.f90 \
          test_hierarchical.f90 test_damping.f90 test_wind.f90 test_iorig.f90 \
@@ -777,7 +776,7 @@ interpolate3D_amr.o: adaptivemesh.o
 ifndef MODDUMPBIN
 MODDUMPBIN=phantommoddump
 endif
-OBJMOD1 = ${OBJSETSTAR} velfield_fromcubes.o set_vfield.o\
+OBJMOD1 = ${OBJSETSTAR} eos_stamatellos.o velfield_fromcubes.o set_vfield.o\
           set_disc.o set_Bfield.o utils_omp.o\
 	  ${MODFILE:.f90=.o} phantom_moddump.o
 OBJMOD = ${OBJMOD1:.F90=.o}

build/Makefile_setups

@@ -1070,6 +1070,17 @@ ifeq ($(SETUP), testapr)
     PERIODIC=yes
 endif
 
+ifeq ($(SETUP), testcoolra)
+#   star cluster formation
+    SETUPFILE= setup_sphere.f90
+    ISOTHERMAL=no
+    GRAVITY=yes
+    CONST_AV=yes
+    IND_TIMESTEPS=yes
+    KNOWN_SETUP=yes
+endif
+
+
 ifeq ($(SETUP), flrw)
 #   constant density FLRW cosmology with perturbations
     GR=yes

data/cooling/Masunaga_2000_collapse.csv

@@ -0,0 +1,183 @@
+-18.796414666523667, 0.760070380999812
+-18.719550137300093, 0.782785698360307
+-18.603801199175187, 0.7738265743823884
+-18.484435106733876, 0.766915250170852
+-18.365069014292565, 0.752560961423816
+-18.245702921851255, 0.7337763366437411
+-18.126336829409944, 0.7401560205313142
+-18.006970736968633, 0.7206625419859547
+-17.887604644527322, 0.7128651505678105
+-17.76823855208601, 0.7151689253049893
+-17.6488724596447, 0.7064854666802383
+-17.529506367203386, 0.703472838177774
+-17.410140274762075, 0.7064854666802383
+-17.290774182320764, 0.7032956247364526
+-17.171408089879453, 0.7048905457083459
+-17.052041997438142, 0.707371533886846
+-16.93267590499683, 0.7109158027132745
+-16.81330981255552, 0.7141056446570611
+-16.69394372011421, 0.71889040757274
+-16.574577627672898, 0.723675170488419
+-16.455211535231587, 0.728459933404098
+-16.335845442790276, 0.7359028979395985
+-16.216479350348965, 0.7419281549445289
+-16.097113257907655, 0.7486622657147439
+-15.977747165466344, 0.7561052302502445
+-15.858381073025033, 0.7646114754336741
+-15.739014980583722, 0.7725860802931388
+-15.619648888142411, 0.7812695389178899
+-15.5002827957011, 0.7901302109839623
+-15.380916703259789, 0.7996997368153203
+-15.261550610818478, 0.8089148357640354
+-15.142184518377167, 0.8197248556846439
+-15.022818425935856, 0.8287627411920386
+-14.903452333494545, 0.8388639073473607
+-14.784086241053235, 0.8502055675919333
+-14.664720148611924, 0.8629649353670779
+-14.545354056170611, 0.8714711805505075
+-14.4259879637293, 0.8838761214430084
+-14.30662187128799, 0.8943317144809741
+-14.187255778846678, 0.90726829569744
+-14.067889686405367, 0.9184327425006913
+-13.948523593964056, 0.9297744027452639
+-13.829157501522745, 0.9432426242856939
+-13.709791409081433, 0.9545842845302674
+-13.590425316640122, 0.9684069329533402
+-13.471059224198811, 0.982229581376413
+-13.3516931317575, 0.9958750163581644
+-13.23232703931619, 1.0130647201663452
+-13.112960946874878, 1.0286595030026326
+-12.993594854433567, 1.0483301949893136
+-12.874228761992256, 1.0694185945065664
+-12.754862669550945, 1.0919247015543903
+-12.635496577109635, 1.1201016387245
+-12.516130484668324, 1.149873496866503
+-12.396764392227013, 1.1831896238349353
+-12.277398299785702, 1.2227082212496194
+-12.158032207344391, 1.2627584589882668
+-12.044091846377684, 1.304474503075336
+-11.93015148541098, 1.3485297645878473
+-11.816211124444273, 1.3914154173876385
+-11.713122226426776, 1.4340844759813685
+-11.615459059883886, 1.4754539693387434
+-11.5232216248156, 1.5181230279324742
+-11.43640992122192, 1.5607650122504477
+-11.34959821762824, 1.604625338977506
+-11.268212245509163, 1.646779986331846
+-11.192252004864692, 1.6877162912771007
+-11.116291764220222, 1.728931074487289
+-11.040331523575752, 1.770424335962411
+-10.958945551456676, 1.8139365648583023
+-10.872133847862994, 1.859015233994446
+-10.785322144269314, 1.9014135498306026
+-10.693084709201027, 1.9450302080758441
+-10.595421542658137, 1.9872660782574565
+-10.49233264464064, 2.030411644104518
+-10.38381801514854, 2.071932753406134
+-10.269877654181835, 2.1165728192750066
+-10.150511561740524, 2.1594584720747974
+-10.031145469299213, 2.202344124874588
+-9.9117793768579, 2.2423943626132354
+-9.79241328441659, 2.2842167347650975
+-9.673047191975279, 2.3271023875648877
+-9.553681099533968, 2.3699880403646785
+-9.439740738567263, 2.411899019237201
+-9.331226109075162, 2.453809998109724
+-9.22271147958306, 2.4970855204804216
+-9.11419685009096, 2.5413357167783874
+-9.011107952073464, 2.5844163043636317
+-8.913444785530572, 2.6260023919270647
+-8.815781618987682, 2.668238262108677
+-8.718118452444791, 2.710474132290289
+-8.620455285901901, 2.752060219853722
+-8.517366387884405, 2.7951408074389663
+-8.414277489866908, 2.837614931247244
+-8.311188591849413, 2.8797425043258262
+-8.202673962357311, 2.922043352769256
+-8.088733601390606, 2.9664884838526753
+-7.969367508949295, 3.009374136652466
+-7.850001416507984, 3.0522597894522563
+-7.730635324066673, 3.0917783868669395
+-7.611269231625361, 3.131474197722944
+-7.49190313918405, 3.1692206607244127
+-7.372537046742739, 3.2046633489887024
+-7.253170954301428, 3.2374478356331706
+-7.133804861860117, 3.265270345920638
+-7.014438769418806, 3.2891941604990333
+-6.895072676977495, 3.3101053465749644
+-6.775706584536184, 3.328358331031074
+-6.656340492094873, 3.34501639451529
+-6.5369743996535625, 3.3595478967036487
+-6.417608307212252, 3.3744338257746502
+-6.298242214770941, 3.3871931935497948
+-6.17887612232963, 3.401547482296832
+-6.059510029888319, 3.414838490395941
+-5.940143937447008, 3.4281294984950494
+-5.820777845005697, 3.4412432931528367
+-5.701411752564384, 3.453648234045338
+-5.5820456601230735, 3.465698748055196
+-5.4626795676817625, 3.478103688947698
+-5.343313475240452, 3.4901542029575565
+-5.223947382799141, 3.5030907841740224
+-5.10458129035783, 3.5154957250665237
+-4.985215197916519, 3.528432306282989
+-4.865849105475208, 3.541723314382098
+-4.746483013033897, 3.555014322481207
+-4.627116920592584, 3.5688369709042798
+-4.5077508281512735, 3.583191259651317
+-4.388384735709963, 3.59825440216364
+-4.269018643268652, 3.6122542640280346
+-4.149652550827341, 3.625899699009786
+-4.03028645838603, 3.640253987756824
+-3.910920365944719, 3.653013355531968
+-3.791554273503408, 3.6652410829831483
+-3.672188181062097, 3.6765827432277205
+-3.552822088620786, 3.686683909383043
+-3.4334559961794753, 3.69607622177308
+-3.3140899037381644, 3.7084811626655814
+-3.1947238112968535, 3.726911360563012
+-3.0753577188555425, 3.738607447690228
+-2.9559916264142316, 3.7503035348174434
+-2.8366255339729207, 3.7623540488273015
+-2.71725944153161, 3.774581776278482
+-2.597893349090299, 3.7914170532040194
+-2.478527256648988, 3.817290215636951
+-2.359161164207677, 3.843872231835168
+-2.239795071766366, 3.87346687653585
+-2.1204289793250553, 3.9060741497389966
+-2.0010628868837443, 3.939744703590072
+-1.8816967944424334, 3.97979494132872
+-1.767756433475725, 4.017771781803906
+-1.659241803983626, 4.060462499818243
+-1.5507271744915236, 4.104322826545301
+-1.4476382764740272, 4.147360095289335
+-1.3445493784565343, 4.191068806072151
+-1.2360347489644319, 4.234734198013756
+-1.122094387997727, 4.277159095866111
+-1.002728295556416, 4.316854906722115
+-0.8833622031151052, 4.350879887455833
+-0.7639961106737942, 4.380651745597837
+-0.6446300182324833, 4.414322299448912
+-0.5361153887403809, 4.45644002733631
+-0.44930368514669894, 4.498675897517922
+-0.373343444502229, 4.539612202463177
+-0.29738320385775907, 4.583333290057768
+-0.22142296321328914, 4.62705437765236
+-0.1400369910942132, 4.671193182644352
+-0.04779955602592523, 4.7128875673108155
+0.03358641609315072, 4.751766227298504
+0.09326946231380617, 4.795756510549198
+0.1692297029582761, 4.844143656182902
+0.277744332450375, 4.885532839922645
+0.39168469341708345, 4.92655775158856
+0.48392212848536786, 4.968468730461082
+0.5598823691298378, 5.0130252528504755
+0.6304168782997053, 5.056839166533378
+0.6955256559949632, 5.100699493260437
+0.7606344336902247, 5.1448847112965845
+0.8257432113854861, 5.19069438587818
+0.8908519890807476, 5.2371538430779525
+0.9559607667760055, 5.282638626350458
+1.015643812996661, 5.324419648699345
+1.0916040536411344, 5.370250982701545
+1.1458613683871839, 5.389527867040845

data/cooling/README

@@ -1 +1,2 @@
 Tabulated cooling functions, first column is temperature, second column is cooling rate
+Masunaga_2000_collapse.csv: log density and log Temperature for the uniform sphere collapse test used by testcoolra