Merged
Conversation
atalyaalon
force-pushed
the
2737-street-view-gps
branch
3 times, most recently
from
18231f9 to
6b0cb2e
Compare
atalyaalon
force-pushed
the
2737-street-view-gps
branch
from
6b0cb2e to
35cf0d6
Compare
Collaborator
Author
|
@ziv17 can you review? |
ziv17
reviewed
Dec 20, 2024
ziv17
reviewed
Dec 20, 2024
Collaborator
ziv17
left a comment
ziv17
left a comment
There was a problem hiding this comment.
Hi @atalyaalon , see my comment below.
atalyaalon
force-pushed
the
2737-street-view-gps
branch
from
e4ddd73 to
68e763a
Compare
Collaborator
Author
|
@ziv17 Thanks for the feedback Updated per your comments—please review again :) |
ziv17
approved these changes
Dec 20, 2024
Comment on lines
23
to
25
| def is_included(self): | ||
| return self.request_params.gps is not None | ||
|
|
Collaborator
There was a problem hiding this comment.
Maybe it is safer to do
return self.request_params.gps and self.request_params.gps.get("lon") and self.request_params.gps.get
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.