[Fix] Only set 'enabled' when the field is updated for ncc endpoint rules

[bgrams]

Changes

Only set the enabled request field when updating an NCC endpoint rule if it has been changed in the configuration. Including this for non-S3 endpoint rules results in a client error during apply.

This also includes a change to make the enabled field conflict with other attributes that imply the endpoint rule type (domain_names, group_id) in order to fail during the plan phase if we know that an error is going to occur.

Fixes #5306

Tests

Unit test added, existing unit tests updated, tested locally

• make test run locally
• relevant change in docs/ folder
• covered with integration tests in internal/acceptance
• using Go SDK
• using TF Plugin Framework
• has entry in NEXT_CHANGELOG.md file

[github-actions]

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

• PR number: 5326
• Commit SHA: 242ab28caea88c584ba48d27a6e3d0c9a107cf26

Checks will be approved automatically on success.

[tanmay-db]

Hi @bgrams, thanks for the fix, by local testing you meant you are able to update the resource on non-aws cloud with local TF build?

[bgrams]

@tanmay-db yes a local build, using standard AWS VPCE rules (i.e. domain_names in the resource). I don't have access to an environment to test more comprehensively than this.

Here's the local config I'm testing with for reference:

provider "databricks" {
  profile = "account"
}

resource "databricks_mws_network_connectivity_config" "config" {
  name   = "test"
  region = "us-west-2"
}

resource "databricks_mws_ncc_private_endpoint_rule" "rule" {
  endpoint_service = "com.amazonaws.vpce.us-west-2.vpce-svc-xxxxxxxxxxxxxxxx"
  domain_names     = ["foo.bar"]

  network_connectivity_config_id = databricks_mws_network_connectivity_config.config.network_connectivity_config_id
}