-
Notifications
You must be signed in to change notification settings - Fork 26
Distributed hive-style join testing with superset satisfaction #256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JSOD11
merged 15 commits into
datafusion-contrib:main
from
JSOD11:jsod/join-tests-12-16-25
Jan 22, 2026
Merged
Changes from 11 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
7339b59
Added join testdata and method to generate parquet from csv.
JSOD11 16fb14d
Added basic single node join test for comparison.
JSOD11 c181e34
Use hive partitioning.
JSOD11 cab524b
Results are the same with hive partitioning and Gene's PR.
JSOD11 58383c8
Fixed configs and achieved optimal distributed plan.
JSOD11 7de49da
Refactoring, adding comments.
JSOD11 23d7e83
Added check to ensure optimal plan is achieved.
JSOD11 543990b
Update based on Nga's comments.
JSOD11 524f1b0
Added second test.
JSOD11 2ded321
Added third test.
JSOD11 b157d0e
Refactor.
JSOD11 23da3d7
Add ORDER BY to queries and switch to snapshot testing.
JSOD11 e304267
Nulls last instead of nulls first.
JSOD11 81948c8
Merge branch 'main' into jsod/join-tests-12-16-25
JSOD11 3709fce
Fix tests.
JSOD11 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| env,service,host | ||
| dev,log,host-y | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| env,service,host | ||
| prod,log,host-x | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| env,service,host | ||
| dev,trace,host-z | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| env,service,host | ||
| prod,trace,host-x | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| timestamp,value | ||
| 2023-01-01T09:00:00,95.5 | ||
| 2023-01-01T09:00:10,102.3 | ||
| 2023-01-01T09:00:20,98.7 | ||
| 2023-01-01T09:12:20,105.1 | ||
| 2023-01-01T09:12:30,100.0 | ||
| 2023-01-01T09:12:40,150.0 | ||
| 2023-01-01T09:12:50,120.8 | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| timestamp,value | ||
| 2023-01-01T09:00:00,75.2 | ||
| 2023-01-01T09:00:10,82.4 | ||
| 2023-01-01T09:00:20,78.9 | ||
| 2023-01-01T09:00:30,85.6 | ||
| 2023-01-01T09:12:30,80.0 | ||
| 2023-01-01T09:12:40,120.0 | ||
| 2023-01-01T09:12:50,92.3 | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| timestamp,value | ||
| 2023-01-01T10:00:00,88.5 | ||
| 2023-01-01T10:00:10,91.2 | ||
| 2023-01-01T10:00:20,87.3 | ||
| 2023-01-01T10:00:30,94.1 | ||
| 2023-01-01T10:12:30,89.5 | ||
| 2023-01-01T10:12:40,95.8 | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| timestamp,value | ||
| 2023-01-01T11:00:00,72.8 | ||
| 2023-01-01T11:00:10,79.4 | ||
| 2023-01-01T11:00:20,76.1 | ||
| 2023-01-01T11:00:30,83.7 | ||
| 2023-01-01T11:12:30,77.2 | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| timestamp,value | ||
| 2023-01-01T10:00:00,310.5 | ||
| 2023-01-01T10:00:10,225.7 | ||
| 2023-01-01T10:00:20,380.2 | ||
| 2023-01-01T10:00:30,205.8 | ||
| 2023-01-01T10:00:40,350.0 | ||
| 2023-01-01T10:12:40,200.0 | ||
| 2023-01-01T10:12:50,205.4 | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| timestamp,value | ||
| 2023-01-01T11:00:00,295.3 | ||
| 2023-01-01T11:00:10,318.6 | ||
| 2023-01-01T11:00:20,342.9 | ||
| 2023-01-01T11:00:30,287.4 | ||
| 2023-01-01T11:00:40,365.2 | ||
| 2023-01-01T11:12:40,310.8 | ||
| 2023-01-01T11:12:50,298.1 | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| timestamp,value | ||
| 2023-01-01T10:00:00,24.8 | ||
| 2023-01-01T10:00:10,72.1 | ||
| 2023-01-01T10:00:20,42.5 | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| -- datafusion-cli -f testdata/join/generate_parquet_from_csv.sql | ||
|
|
||
| -- Generate parquet dim files from csv files. | ||
| COPY (SELECT * FROM "testdata/join/csv/dim/d_dkey=A/data0.csv") | ||
| TO "testdata/join/parquet/dim/d_dkey=A/data0.parquet" | ||
| STORED AS PARQUET; | ||
|
|
||
| COPY (SELECT * FROM "testdata/join/csv/dim/d_dkey=B/data0.csv") | ||
| TO "testdata/join/parquet/dim/d_dkey=B/data0.parquet" | ||
| STORED AS PARQUET; | ||
|
|
||
| COPY (SELECT * FROM "testdata/join/csv/dim/d_dkey=C/data0.csv") | ||
| TO "testdata/join/parquet/dim/d_dkey=C/data0.parquet" | ||
| STORED AS PARQUET; | ||
|
|
||
| COPY (SELECT * FROM "testdata/join/csv/dim/d_dkey=D/data0.csv") | ||
| TO "testdata/join/parquet/dim/d_dkey=D/data0.parquet" | ||
| STORED AS PARQUET; | ||
|
|
||
| -- Generate parquet fact files from csv files. | ||
| COPY (SELECT * FROM "testdata/join/csv/fact/f_dkey=A/data0.csv") | ||
| TO "testdata/join/parquet/fact/f_dkey=A/data0.parquet" | ||
| STORED AS PARQUET; | ||
|
|
||
| COPY (SELECT * FROM "testdata/join/csv/fact/f_dkey=B/data0.csv") | ||
| TO "testdata/join/parquet/fact/f_dkey=B/data0.parquet" | ||
| STORED AS PARQUET; | ||
|
|
||
| COPY (SELECT * FROM "testdata/join/csv/fact/f_dkey=B/data1.csv") | ||
| TO "testdata/join/parquet/fact/f_dkey=B/data1.parquet" | ||
| STORED AS PARQUET; | ||
|
|
||
| COPY (SELECT * FROM "testdata/join/csv/fact/f_dkey=B/data2.csv") | ||
| TO "testdata/join/parquet/fact/f_dkey=B/data2.parquet" | ||
| STORED AS PARQUET; | ||
|
|
||
| COPY (SELECT * FROM "testdata/join/csv/fact/f_dkey=C/data0.csv") | ||
| TO "testdata/join/parquet/fact/f_dkey=C/data0.parquet" | ||
| STORED AS PARQUET; | ||
|
|
||
| COPY (SELECT * FROM "testdata/join/csv/fact/f_dkey=C/data1.csv") | ||
| TO "testdata/join/parquet/fact/f_dkey=C/data1.parquet" | ||
| STORED AS PARQUET; | ||
|
|
||
| COPY (SELECT * FROM "testdata/join/csv/fact/f_dkey=D/data0.csv") | ||
| TO "testdata/join/parquet/fact/f_dkey=D/data0.parquet" | ||
| STORED AS PARQUET; | ||
|
|
Git LFS file not shown
Git LFS file not shown
Git LFS file not shown
Git LFS file not shown
Git LFS file not shown
Git LFS file not shown
Git LFS file not shown
Git LFS file not shown
Git LFS file not shown
Git LFS file not shown
Git LFS file not shown
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
arrowwas updated in #268. If you update withmainyou should be fine.