Fix metrics collection bug: preserve PartitionIsolatorExec in plan #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayshrivastava
force-pushed
the
js/fix-metrics-bug
branch
from
49883e8 to
c83a03c
Compare
jayshrivastava
commented
Jan 26, 2026
| #[ignore] // https://github.com/datafusion-contrib/datafusion-distributed/issues/260 | ||
| #[ignore] | ||
| async fn test_metrics_collection_e2e_4() { | ||
| run_metrics_collection_e2e_test("SELECT distinct company from table2").await; |
Collaborator
Author
There was a problem hiding this comment.
FYI @marc-pydantic since you added this test.
jayshrivastava
force-pushed
the
js/fix-metrics-bug
branch
from
c83a03c to
117517d
Compare
- Fix stage_metrics_rewriter to correctly match metrics to nodes in pre-order traversal - Update test assertions to allow empty metrics for PartitionIsolatorExec nodes - Fix assert_metrics_present_in_plan to handle PartitionIsolatorExec wrapped in MetricsWrapperExec Fixes issue where PartitionIsolatorExec nodes were missing from displayed plans after metrics rewriting. All metrics collection tests now pass.
jayshrivastava
force-pushed
the
js/fix-metrics-bug
branch
from
2c79e5d to
7e22b1c
Compare
gabotechs
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dupe of #281 with minor fixes
PartitionIsolatorExecnodesassert_metrics_present_in_plantest helper to handlePartitionIsolatorExecwrapped inMetricsWrapperExeccount_plan_nodes_up_to_network_boundarytest helper now that network boundary nodes have metricsFixes issue where PartitionIsolatorExec nodes were missing from displayed plans after metrics rewriting. All metrics collection tests now pass.