Edson.petry/ddf console: fix generated protos out_dir path
#316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e6200a1.
- only sends 0, will be extended in the future
- switch codegen to tonic-prost-build - flatten observability module exports - make protobuf module public and update imports to tonic-generated paths
- add workspace dependency on datafusion-distributed - fix console imports for observability client - changed console entry point to be async w/ tokio
- Tried ophan-rule-breaking Arc<Worker> impls, added SharedWorker(Arc<worker>) - Updated console example to use SharedWorker so both flight and observability share the same underlying state - re-exported SharedWorker
- method isn't being used anywhere at the moment
…nto edson.petry/ddf-console
Replaces the build.rs-based proto compilation with an explicit generation system similar to that of Apache DataFusion's proto crate. - add src/observability/gen for code generation - add src/observability/generated/ for generated code - remove root build.rs - remove observability module from being coupled with protobuf module - remove src/protobufobservability.rs - switch protobuf module back to private
… service - re-export on TaskData - defined observability service struct in src/observability/service.rs
- removed tonic-prost-build build dependency - import datafusion-distributed properly in console/Cargo.toml - remove observability service trait implementation for Worker - add Apache DataFusion Proto crate hyper link in src/observability docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for merged PR Add functionality for worker-console communication #297
where generated protobuf code would end up in
src/observability/src/generated/instead ofsrc/observability/generated/.