Don't drop aggregate type qualifier for alias parameter #22393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#22393" |
ntrel
force-pushed
the
alias-param-qual
branch
from
f51aa99 to
d0fd874
Compare
This comment was marked as outdated.
This comment was marked as outdated.
ibuclaw
added a commit
to ibuclaw/dmd
that referenced
this pull request
Jan 13, 2026
thewilsonator
pushed a commit
that referenced
this pull request
Jan 13, 2026
ntrel
force-pushed
the
alias-param-qual
branch
from
d0fd874 to
e156726
Compare
ntrel
force-pushed
the
alias-param-qual
branch
from
e156726 to
8433960
Compare
Contributor
Author
|
Given that this one doesn't break any core stuff, perhaps it doesn't need an edition. |
thewilsonator
approved these changes
Jan 21, 2026
ntrel
added a commit
to ntrel/phobos
that referenced
this pull request
Jan 24, 2026
Now dlang/dmd#22393 is fixed, we can use separate alias parameters instead of a single variadic parameter. Update staticIndexOf, Erase, EraseAll, ReplaceAll. Also improve staticIndexOf example.
thewilsonator
pushed a commit
to dlang/phobos
that referenced
this pull request
Jan 24, 2026
Now dlang/dmd#22393 is fixed, we can use separate alias parameters instead of a single variadic parameter. Update staticIndexOf, Erase, EraseAll, ReplaceAll. Also improve staticIndexOf example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reboot of #11320.
Fixes #17959.
I'm going to see what this breaks first, then maybe enable the change from the 2024 edition.