-
-
Notifications
You must be signed in to change notification settings - Fork 44
additional tests for merging foreign keys and constraint violations #2219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Footnotes
|
Hydrocharged
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
| Query: "select dolt_checkout('feature')", | ||
| SkipResultsCheck: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do like adding results checking for these. We used to skip because we didn't yet support their output, but that was fixed quite a while ago.
| Query: "select dolt_merge('main')", | ||
| SkipResultsCheck: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For dolt_merge we'd do something like:
{
Query: "select strpos(dolt_merge('main')::text, 'merge successful') > 1;",
Expected: []sql.Row{{"t"}},
},
No description provided.