[typescript-operations] Cut down avoidOptionals to only support object, inputValue and defaultValue (+ minor drive-by fixes)
#10579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: cddb06a The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
eddeee888
commented
Jan 21, 2026
| "ignore": [ | ||
| "website", | ||
| "example-*", | ||
| "dev-test*", |
Collaborator
Author
There was a problem hiding this comment.
Similar to example folders, the modules in dev-test (which includes the example for Apollo tooling migration), should be ignored, otherwise it'd show up in Changeset interface
Contributor
🚀 Snapshot Release (
|
| Package | Version | Info |
|---|---|---|
@graphql-codegen/cli |
6.1.2-alpha-20260121105018-cddb06acaff1e8871880dbab01eea71c1639578b |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/introspection |
5.0.1-alpha-20260121105018-cddb06acaff1e8871880dbab01eea71c1639578b |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/visitor-plugin-common |
7.0.0-alpha-20260121105018-cddb06acaff1e8871880dbab01eea71c1639578b |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript-document-nodes |
5.0.8-alpha-20260121105018-cddb06acaff1e8871880dbab01eea71c1639578b |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/gql-tag-operations |
5.1.3-alpha-20260121105018-cddb06acaff1e8871880dbab01eea71c1639578b |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript-operations |
6.0.0-alpha-20260121105018-cddb06acaff1e8871880dbab01eea71c1639578b |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript-resolvers |
6.0.0-alpha-20260121105018-cddb06acaff1e8871880dbab01eea71c1639578b |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typed-document-node |
6.1.6-alpha-20260121105018-cddb06acaff1e8871880dbab01eea71c1639578b |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript |
6.0.0-alpha-20260121105018-cddb06acaff1e8871880dbab01eea71c1639578b |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/client-preset |
6.0.0-alpha-20260121105018-cddb06acaff1e8871880dbab01eea71c1639578b |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/graphql-modules-preset |
5.1.3-alpha-20260121105018-cddb06acaff1e8871880dbab01eea71c1639578b |
npm ↗︎ unpkg ↗︎ |
eddeee888
commented
Jan 21, 2026
Comment on lines
-11
to
-12
| * | ||
| * Note: In most configurations, this plugin requires you to use `typescript as well, because it depends on its base types. |
Collaborator
Author
There was a problem hiding this comment.
Removing this makes me feel we are so close now!
eddeee888
commented
Jan 21, 2026
Comment on lines
-178
to
-180
| // FIXME: this is the legacy avoidOptionals which was used to make Result fields non-optional. This use case is no longer valid. | ||
| // It's also being used for Variables so people could already be using it. | ||
| // Maybe it's better to deprecate and remove, to see what users think. |
Collaborator
Author
There was a problem hiding this comment.
Let's keep it for now to keep the scope of this project manageable
eddeee888
changed the title
avoidOptionals to only support object, inputValue and defaultValueavoidOptionals to only support object, inputValue and defaultValue (+ minor drive-by fixes)
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates
avoidOptionalsconfig option intypescript-operationsto only supportobject,inputValueanddefaultValue.Strictly speaking, this is a type change because the rest of the options did not have any effect on the plugin. However, since it's an interface change, it's a breaking change and it's mentioned so in the changeset
I've also did a couple of drove-by fixes:
dev-test-apollo-toolingRelated #10496
Type of change