-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
chore: use Vite+ #5772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
chore: use Vite+ #5772
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying egg with
|
| Latest commit: |
8ff913f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e84088a0.egg-cci.pages.dev |
| Branch Preview URL: | https://vite-plus.egg-cci.pages.dev |
Deploying egg-v3 with
|
| Latest commit: |
8ff913f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d490640e.egg-v3.pages.dev |
| Branch Preview URL: | https://vite-plus.egg-v3.pages.dev |
Summary of ChangesHello @fengmk2, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request orchestrates a significant shift in the project's development workflow by adopting Vite+ as the central toolchain. This change streamlines various development tasks like building, testing, linting, and formatting under a single command-line interface, aiming to simplify configuration and improve consistency across the codebase. The accompanying documentation ensures that developers can quickly adapt to the new system. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request migrates the project's toolchain to Vite+, a unified development tool. The changes are extensive, touching numerous package.json files, test files, and configurations across the monorepo to replace tools like oxlint, oxfmt, tsdown, and vitest with vite-plus commands and imports. The addition of documentation in CLAUDE.md explaining the new workflow is a valuable improvement. The migration appears to be consistently and correctly applied. I have one point of feedback regarding a potential inconsistency between the new documentation and the project's dependencies.
| "vitest": "catalog:", | ||
| "vite-plus": "catalog:" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new CLAUDE.md documentation explicitly states that vitest should not be installed directly as vite-plus wraps it:
Do not install Vitest, Oxlint, Oxfmt, or tsdown directly: Vite+ wraps these tools. They must not be installed directly.
...
You must not installvitestto import test utilities.
However, vitest is still listed as a dev dependency here and in other packages. If it's required for type definitions or other reasons not covered by vite-plus, the documentation should be updated to clarify this. If it's not needed, it should be removed to align with the new development guidelines and avoid confusion.
No description provided.