Publishing proper links to images shared from Slack to IRC #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proper (direct) links for uploaded files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of now, bots can get public URLs for images - the problem is, images aren't automatically shared, so the public links are 404 - until somebody shares them. This effectively prohibits the majority of users on IRC side from seeing the uploaded images - they only see notifications sent by the bot, but visiting the link results in "File not found". This also makes the image link forwarding capability, as it is, kind of useless.
In order to share a file, you need to either go into image properties and press a "Get public link" button or call
files.sharedPublicURLfrom Web API. The problem is - bots can't usefiles.sharedPublicURL, only users (or apps with appropriate scopes) can do that. So, I've added a capability of using a user token additionally - solely for generating proper, accessible links.