fix: Replace deprecated Tooltip and Popover components with Tooltip2 … #1667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
requested changes
Dec 16, 2024
Member
codebytere
left a comment
codebytere
left a comment
There was a problem hiding this comment.
Tests need to be updated; the changes are also not drop-in and likely require other refactoring!
Contributor
Author
|
I have updated the snapshots to correctly test for Tooltip2 components and also gone through the Tooltip2 & Poppver2 migration guide to see any additional changes required for the project which needs to be done. |
codebytere
approved these changes
Dec 17, 2024
erickzhao
approved these changes
Dec 17, 2024
Member
erickzhao
left a comment
erickzhao
left a comment
There was a problem hiding this comment.
LGTM 
Thanks for the contribution @Santhoshmani1!
Santhoshmani1
deleted the
fix/Deprecated-tooltip-and-popover-components
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1095
fix: Replace deprecated Tooltip and Popover components with Tooltip2
Popovercomponent in thesrc/renderer/components/commands-action-button.tsxtoPopover2andTooltipcomponents in thesrc/renderer/components/settings-electron.tsx&src/renderer/components/version-select.tsxtoTooltip2.