Use shadow width instead of custom size #437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leolost2605
force-pushed
the
leolost/shadow-width
branch
from
5450618 to
2a81e75
Compare
danirabbit
reviewed
Jul 27, 2025
Member
danirabbit
left a comment
danirabbit
left a comment
There was a problem hiding this comment.
Nice job! This works perfectly for me both HiDPI and LoDPI. Just one small suggestion
Co-authored-by: Danielle Foré <[email protected]>
danirabbit
approved these changes
Jul 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What we currently achieve by setting a custom size via our wayland protocol is actually supported by default in wayland via the shadow width which maps to frame rect and buffer rect in mutter. I only found out about shadow width recently so I always thought frame rect and buffer rect are somewhat broken or rather use something else 😬
Setting the shadow width ourselves allows us to remove the custom size method from our wayland protocol and the custom rect handling which has caused a few issues in the past because of wrong coordinate conversion on different scaling factors and methods. (See elementary/wingpanel#568, elementary/wingpanel#594, elementary/gala#2139, etc.)
Fixes #351 (On X that requires a dock restart for some reason? I think that's due to a bug in gala but I will investigate in a follow up since ig it's at least better than main)