Fix windows hInstance for raw window handle #371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
..and make windows' hwnd a non-option, removing lots of 'unwrap'
Owner
|
Nice! Yeah, this looks much clear. Thanks for the cleanup :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
..and make windows' hwnd a non-option, removing lots of 'unwrap'.
I think I actually broke the
hinstancein a previous PR! Turns out thatGetWindowLongPtrW(raw_hwnd, GWLP_HINSTANCE)always returned null. So instead, I make now sure to use the same hinstance that was used when creating the window in the rist place.I noticed this when trying to use wgpu with a Vulkan backend on windows which requires a valid hinstance. I didn't notice so far because wgpu always fell back to OpenGL because it (correctly) couldn't create a surface for Vulkan. But now when disabling OpenGL that error of course bubbled up.