test(ses): cover the allowNextEvalToBeUnsafe failure after stack overflow

[naugtur]

Description

Just a test covering an edge-case that's rare but known but often hard to recall.

[mhofman]

I'm surprised you managed to build a test reproducing this. I'll try to look how we actually end up in this case.

[mhofman]

I would recommend avoiding tail recursion here as that is an explicitly allowed optional optimization.

[mhofman]

Interesting, I thought we couldn't actually trigger this case. We may have broken the stack overflow protection at some point.

[naugtur]

Took me a good 10 minutes of staring at this to figure out why it works.
I suggest we add a lengthy comment to explain it 😅
Something like this maybe:

Suggested change

	const allowEvalProperties = freeze({
	eval: {
	value: props => {
	const { eval: evalProp } = props;
	delete evalScope.eval;
	defineProperties(evalScope, { eval: evalProp });
	},
	// This conforms to the shape of evalScope properties, but instead of evaluating what arrives as first
	// argument, it accepts a new shape to replace eval with.
	// As a result, when `apply(evaluate, globalObject, [oneTimeEvalProperties]);` is called below,
	// the same exact stack depth is reached and the same optimizations are applied to it before the
	// FERAL_EVAL is put in place, making it impossible for a stack overflow error to occur in the process
	// of getting eval for the main call to the evaluator if it didn't occur in revealing eval.
	const allowEvalProperties = freeze({
	eval: {
	value: props => {
	const { eval: evalProp } = props;
	delete evalScope.eval;
	defineProperties(evalScope, { eval: evalProp });
	},