Skip to content

Conversation

@kentcdodds
Copy link
Member

@kentcdodds kentcdodds commented Jan 22, 2026

Adds preferred editor selection and persistence, and refines workshop accessibility checks during onboarding.

The workshop setup flow now displays available workshops even if access isn't fully verified, preventing an empty list when the user is not explicitly logged out. Additionally, users can now choose and save their preferred code editor, which the open command will use, avoiding unexpected editor launches like Vim.


Open in Cursor Open in Web


Note

Editor preference (persisted) and usage

  • Adds config editor subcommand and --editor flag to set preferred editor; docs updated
  • open resolves preferred editor (prompts once, persists) and sets EPICSHOP_EDITOR
  • New editor utilities: detect installed editors, map Windows executables to CLI commands, format labels, and provide defaults
  • Config storage extended with preferredEditor (get/set/clear)

Onboarding and workshop selection improvements

  • Access checks now skip hosts known as logged-out; continue showing workshops when access is unknown
  • Selection UIs updated to display accessible and “unknown access” workshops, with messaging and filtering tweaks

Other

  • CLI config flow adds interactive editor picker; silent output includes preferred editor status

Written by Cursor Bugbot for commit 151c1a0. This will update automatically on new commits. Configure here.

@cursor
Copy link

cursor bot commented Jan 22, 2026

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@nx-cloud
Copy link

nx-cloud bot commented Jan 22, 2026

View your CI Pipeline Execution ↗ for commit 151c1a0

Command Status Duration Result
nx run-many --target typecheck ✅ Succeeded 4s View ↗
nx lint ✅ Succeeded 21s View ↗
nx run-many --target build ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-01-22 19:56:22 UTC

@kentcdodds kentcdodds marked this pull request as ready for review January 22, 2026 19:16
cursor[bot]

This comment was marked as outdated.

…e names

The getSupportedEditorCommands function was returning executable names like 'Code.exe' and 'Cursor.exe' on Windows, which are not available in PATH. Windows PATH typically contains 'code.cmd' or just 'code'. Added WINDOWS_CLI_COMMANDS mapping to convert executable names to their CLI command equivalents, matching the behavior on macOS and Linux platforms.

Co-authored-by: me <[email protected]>
@cursor
Copy link

cursor bot commented Jan 22, 2026

Bugbot Autofix resolved the bug found in the latest run.

  • ✅ Fixed: Windows editor detection returns wrong command names
    • Added WINDOWS_CLI_COMMANDS mapping to convert Windows executable names (like 'Code.exe') to their CLI commands (like 'code') that are actually available in PATH, matching macOS/Linux behavior.

cursor[bot]

This comment was marked as outdated.

@cursor
Copy link

cursor bot commented Jan 22, 2026

Bugbot Autofix resolved the bug found in the latest run.

  • ✅ Fixed: CLion missing from editor labels mapping
    • Added the missing clion: 'CLion' entry to the EDITOR_LABELS map for consistent branding display.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is ON. A Cloud Agent has been kicked off to fix the reported issue.

When no available editors are detected but a default editor exists, the function now returns null instead of the default editor when the user declines. This ensures the user's explicit declination is respected for the immediate action, not just for saving preferences.

Co-authored-by: me <[email protected]>
@cursor
Copy link

cursor bot commented Jan 22, 2026

Bugbot Autofix resolved the bug found in the latest run.

  • ✅ Fixed: User choice ignored when declining default editor
    • Modified resolvePreferredEditor to return null when user declines the default editor, ensuring their choice is respected for the immediate action.

@kentcdodds kentcdodds merged commit 130deb4 into main Jan 22, 2026
9 of 10 checks passed
@kentcdodds kentcdodds deleted the cursor/cli-setup-experience-7d97 branch January 23, 2026 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants