Extras inline file opening #555
Merged
+46
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: me <[email protected]>
Co-authored-by: me <[email protected]>
|
Cursor Agent can help with this pull request. Just |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
- Add fallback to data.extra when playground is null to preserve file link functionality - Use specific properties in useMemo dependencies instead of entire playground object to prevent unnecessary re-computation Co-authored-by: me <[email protected]>
|
Bugbot Autofix resolved both of the 2 bugs found in the latest run.
|
Add data.extra.name and data.extra.fullPath to the dependency array to ensure the memo recomputes when navigating between extras without a playground. Previously, when playground was null, the dependencies remained [undefined, undefined], causing stale InlineFile closures. Co-authored-by: me <[email protected]>
|
Bugbot Autofix resolved the bug found in the latest run.
|
…d info Co-authored-by: me <[email protected]>
|
Bugbot Autofix resolved the bug found in the latest run.
|
Co-authored-by: me <[email protected]>
Co-authored-by: me <[email protected]>
Co-authored-by: me <[email protected]>
...hop-app/app/routes/_app+/exercise+/$exerciseNumber_.$stepNumber.$type+/__shared/step-mdx.tsx
Show resolved
Hide resolved
Co-authored-by: me <[email protected]>
...hop-app/app/routes/_app+/exercise+/$exerciseNumber_.$stepNumber.$type+/__shared/step-mdx.tsx
Show resolved
Hide resolved
Co-authored-by: me <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Playground app info for InlineFile components in Extras to ensure file links open in the Playground.
Note
Low Risk
Low risk UI/UX change around editor link enablement; main risk is inadvertently disabling valid
InlineFilelinks if playground/appName matching logic is wrong or loader data is missing.Overview
Inline file editor links are now tied to the active Playground context. Extras’ MDX
InlineFilelinks now resolve against the playground app (not the extra app) and are disabled with a tooltip until the playground is set to that extra.Reusable disabled-state support was added to MDX inline-file rendering.
createInlineFileComponentnow accepts an optionalgetDisabledReasoncallback to render a consistent tooltip/disabled UI, and the exercise stepInlineFilelogic was updated to block playground opens until the playground matches the current step (with a small fix to render{children}properly when no app is available).Written by Cursor Bugbot for commit 9e8a93e. This will update automatically on new commits. Configure here.