-
Notifications
You must be signed in to change notification settings - Fork 36
Spp playground shortcut #557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: me <[email protected]>
|
Cursor Agent can help with this pull request. Just |
- Check for s+p+p element existence before immediately clicking s+p to allow s+p+p shortcut to work - Remove redundant waitingForSecondP reset as spSequence.clear() already handles it via onClear callback Co-authored-by: me <[email protected]>
|
Bugbot Autofix resolved both of the 2 bugs found in the latest run.
|
- Fix s+p shortcut not triggering when s+p+p element exists and timeout expires - Remove redundant state setting when no target element exists - Add fallback to trigger s+p action in onClear when waiting for second p times out Co-authored-by: me <[email protected]>
|
Bugbot Autofix resolved both bugs found in the latest run.
|
- Reset waitingForSecondP flag before clearing sequence to prevent onClear callback from triggering unintended s+p action - Fix inconsistent indentation in s+p handler (lines 260-267 now properly use 3 tabs) Co-authored-by: me <[email protected]>
|
Bugbot Autofix resolved 2 of the 2 bugs found in the latest run.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
The g+s keyboard action doesn't exist in the codebase - removed the unused references that were causing confusion. Co-authored-by: me <[email protected]>
Add
s+p+pkeyboard shortcut to reset the playground.Note
Low Risk
Low risk UI/UX change that tweaks client-side keyboard shortcut sequencing; main risk is accidental triggering or timing edge cases around the updated
s+p/s+p+pdisambiguation.Overview
Adds a new keyboard shortcut,
s+p+p, to reset the playground to the current exercise and documents it in the keyboard shortcuts dialog.Updates the playground reset button to advertise
data-keyboard-action="s+p+p", and extends the keyboard shortcut handler to distinguishs+pvss+p+pby briefly waiting for a secondpwhen a reset target exists (falling back tos+pon timeout).Written by Cursor Bugbot for commit b514c43. This will update automatically on new commits. Configure here.