compiler: simplify v3_core #10487
compiler: simplify v3_core #10487
Conversation
CT Test Results 2 files 333 suites 8m 51s ⏱️ For more details on these failures, see this check. Results for commit 401988e. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
simplification of v3_core. the changes make application and function calls to use ANF format. the only visible effect is the removal one specific beam optimisation that deals with a case of cases, that is ``` case (case X of ... end) of ... end ``` this optimisation does not happen too often and the generated code is almost equivalent in efficiency.
kikofernandez
force-pushed
the
kiko/compiler/simplify-v3-core-to-anf-format
branch
from
c9c5397 to
401988e
Compare
|
I'm not sure this is actually this rare - given that |
bjorng
left a comment
bjorng
left a comment
There was a problem hiding this comment.
You've forgotten to include the changes to v3_core.
Do you have any compelling reason for targeting the maint branch? We usually only do bug fixes for the compiler in the maint branch.
3 participants
simplification of v3_core. the changes make application and function calls to use ANF format. the only visible effect is the removal one specific beam optimisation that deals with a case of cases, that is
this optimisation does not happen too often and the generated code is almost equivalent in efficiency.