feat: Add top-level-interop rule #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new rule that checks that the top-level item in a JSON file is either an array or an object, as suggested by RFC8259. Not turned on in the recommended config because the software that had this issue is almost entirely obsolete. Refs #68.
Contributor
Author
|
I clicked through the CLA. |
nzakas
requested changes
Dec 3, 2024
Member
nzakas
left a comment
nzakas
left a comment
There was a problem hiding this comment.
Thanks for putting this together. Overall, it looks good. Just some areas to clean up before merging.
Contributor
Author
|
Made requested changes. |
nzakas
previously approved these changes
Dec 3, 2024
Member
nzakas
left a comment
nzakas
left a comment
There was a problem hiding this comment.
LGTM. Waiting for a second review before merging.
mdjermanovic
reviewed
Dec 4, 2024
mdjermanovic
reviewed
Dec 4, 2024
Co-authored-by: Milos Djermanovic <[email protected]>
nzakas
approved these changes
Dec 4, 2024
Member
nzakas
left a comment
nzakas
left a comment
There was a problem hiding this comment.
LGTM. Waiting for @mdjermanovic to re-review.
mdjermanovic
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new rule that checks that the top-level item in a JSON file is either an array or an object, as suggested by RFC8259. Not turned on in the recommended config because the software that had this issue is almost entirely obsolete.
Refs #68.
Prerequisites checklist
What is the purpose of this pull request?
As discussed in #68, add a new rule to enforce the top-level item in a JSON doc be an array or object.
What changes did you make? (Give an overview)
Added src/rules/top-level-interop.js and tests/rules/top-level-interop.test.js
Related Issues
Refs #68
Is there anything you'd like reviewers to focus on?
Should this be in the recommended set? I could be persuaded either way.