test: ensure pnpm type support test works when @eslint/core is updated#354
Merged
lumirlumir merged 1 commit intomainfrom Jan 13, 2026
Merged
test: ensure pnpm type support test works when @eslint/core is updated#354lumirlumir merged 1 commit intomainfrom
@eslint/core is updated#354lumirlumir merged 1 commit intomainfrom
Conversation
@eslint/core is updated@eslint/core is updated
|
Hi @fasttime!, thanks for the Pull Request The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.
To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page. Read more about contributing to ESLint here |
@eslint/core is updated@eslint/core update
@eslint/core update@eslint/core is updated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Prevent an error in the pnpm type support test of
config-helperswhen@eslint/coreis updated to a version that hasn't been published to npm yet. This happens when a Release Please PR is updated or merged. Examples in CI:What changes did you make? (Give an overview)
Added a
pnpm-worspace.yamlfile in the test directory to override the location of@eslint/core. With this configuration, pnpm no longer attempts to install@eslint/coreinnode_modules, butnode_modules/.pnpmis still populated with the files pnpm needs to resolve it. I verified that the pnpm type support test still fails es expected iftools/dedupe-types.jsis reverted to remove the changes introduced in #289.Related Issues
Is there anything you'd like reviewers to focus on?