Skip to content

test: ensure pnpm type support test works when @eslint/core is updated#354

Merged
lumirlumir merged 1 commit intomainfrom
fix-pnpm-type-support-test
Jan 13, 2026
Merged

test: ensure pnpm type support test works when @eslint/core is updated#354
lumirlumir merged 1 commit intomainfrom
fix-pnpm-type-support-test

Conversation

@fasttime
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request?

Prevent an error in the pnpm type support test of config-helpers when @eslint/core is updated to a version that hasn't been published to npm yet. This happens when a Release Please PR is updated or merged. Examples in CI:

What changes did you make? (Give an overview)

Added a pnpm-worspace.yaml file in the test directory to override the location of @eslint/core. With this configuration, pnpm no longer attempts to install @eslint/core in node_modules, but node_modules/.pnpm is still populated with the files pnpm needs to resolve it. I verified that the pnpm type support test still fails es expected if tools/dedupe-types.js is reverted to remove the changes introduced in #289.

Related Issues

Is there anything you'd like reviewers to focus on?

@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Jan 10, 2026
@eslint-github-bot eslint-github-bot bot added the bug Something isn't working label Jan 10, 2026
@fasttime fasttime changed the title fix: ensure pnpm type support test works when @eslint/core is updated chore: ensure pnpm type support test works when @eslint/core is updated Jan 10, 2026
@eslint-github-bot
Copy link

Hi @fasttime!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

  • The length of the commit message must be less than or equal to 72

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

@fasttime fasttime changed the title chore: ensure pnpm type support test works when @eslint/core is updated chore: ensure pnpm type support test works on @eslint/core update Jan 10, 2026
@fasttime fasttime added chore and removed bug Something isn't working chore labels Jan 10, 2026
@fasttime fasttime changed the title chore: ensure pnpm type support test works on @eslint/core update test: ensure pnpm type support test works when @eslint/core is updated Jan 10, 2026
@fasttime fasttime marked this pull request as ready for review January 10, 2026 16:31
@lumirlumir lumirlumir moved this from Needs Triage to Triaging in Triage Jan 13, 2026
Copy link
Member

@lumirlumir lumirlumir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lumirlumir lumirlumir merged commit ec018aa into main Jan 13, 2026
32 checks passed
@lumirlumir lumirlumir deleted the fix-pnpm-type-support-test branch January 13, 2026 13:30
@github-project-automation github-project-automation bot moved this from Triaging to Complete in Triage Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

2 participants