Skip to content

[release-3.5] Fix error in pull-etcd-release-tests when running in Prow #20293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmhbnz merged 1 commit into from
Jul 8, 2025
+5 −5
Merged

[release-3.5] Fix error in pull-etcd-release-tests when running in Prow #20293

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions scripts/test_images.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,14 @@ source ./scripts/test_lib.sh

function startContainer {
# run docker in the background
docker run -d --rm --name "${RUN_NAME}" "${IMAGE}"
docker run -d --rm --name "${RUN_NAME}" "${TEST_IMAGE}"

# wait for etcd daemon to bootstrap
sleep 5
}

function runVersionCheck {
Out=$(docker run --rm "${IMAGE}" "${@}")
Out=$(docker run --rm "${TEST_IMAGE}" "${@}")
foundVersion=$(echo "$Out" | head -1 | rev | cut -d" " -f 1 | rev )
if [[ "${foundVersion}" != "${VERSION}" ]]; then
echo "error: Invalid Version. Got $foundVersion, expected $VERSION. Error: $Out"
Expand Down Expand Up @@ -45,15 +45,15 @@ else
echo "Terminating test, VERSION not supplied"
exit 1
fi
IMAGE=${IMAGE:-"${REPOSITARY}:${TAG}"}
TEST_IMAGE=${TEST_IMAGE:-"${REPOSITARY}:${TAG}"}

# ETCD related values
RUN_NAME="test_etcd"
KEY="foo"
VALUE="bar"

if [[ "$(docker images -q "${IMAGE}" 2> /dev/null)" == "" ]]; then
echo "${IMAGE} not present locally"
if [[ "$(docker images -q "${TEST_IMAGE}" 2> /dev/null)" == "" ]]; then
echo "${TEST_IMAGE} not present locally"
exit 1
fi

Expand Down
Loading