Keep the --snapshot-count flag
#21162
Conversation
We won't generate v2 snapshot files in 3.8 anymore, but etcd is still generating snapshot periodically and will keep this behaviour. During etcd generating snapshot, it does the following two things: 1. generate a snapshot entry in WAL file 2. purge old raft entries So we need to keep the flag --snapshot-count so that users can configure how frequently the snapshot is generated. Signed-off-by: Benjamin Wang <[email protected]>
|
Link to #20187 |
|
/retest |
|
@ahrtr: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
... and 20 files with indirect coverage changes @@ Coverage Diff @@
## main #21162 +/- ##
==========================================
- Coverage 68.42% 68.38% -0.04%
==========================================
Files 429 429
Lines 35267 35267
==========================================
- Hits 24132 24118 -14
- Misses 9744 9754 +10
- Partials 1391 1395 +4 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, fuweid The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Backported to #21163 |
3 participants
We won't generate v2 snapshot files in 3.8 anymore, but etcd is still generating snapshot periodically and will keep this behaviour. During etcd generating snapshot, it does the following two things:
So we need to keep the flag
--snapshot-countso that users can configure how frequently the snapshot is generated.cc @fuweid @ivanvc @jberkus @serathius
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.