Skip to content

Conversation

@chfast
Copy link
Member

@chfast chfast commented Jan 17, 2026

🗒️ Description

Port the following legacy static tests related to EIP-7610:

  • stCreate2/RevertInCreateInInitCreate2ParisFiller.json
  • stCreate2/create2collisionStorageParisFiller.json

These tests verify that CREATE/CREATE2 operations fail when targeting an address with pre-existing storage, per EIP-7610 collision rules.

🔗 Related Issues or PRs

N/A.

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
  • Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

Copilot AI review requested due to automatic review settings January 17, 2026 09:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@codecov
Copy link

codecov bot commented Jan 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.14%. Comparing base (f9ae69d) to head (cea86ee).
⚠️ Report is 6 commits behind head on forks/amsterdam.

Additional details and impacted files
@@               Coverage Diff                @@
##           forks/amsterdam    #2031   +/-   ##
================================================
  Coverage            86.14%   86.14%           
================================================
  Files                  599      599           
  Lines                39472    39472           
  Branches              3780     3780           
================================================
  Hits                 34004    34004           
  Misses                4847     4847           
  Partials               621      621           
Flag Coverage Δ
unittests 86.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@danceratopz danceratopz self-assigned this Jan 19, 2026
Copy link
Collaborator

@LouisTsai-Csie LouisTsai-Csie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave small suggestion, otherwise LGTM! Thanks

Port the following legacy static tests related to EIP-7610:
- stCreate2/RevertInCreateInInitCreate2ParisFiller.json
- stCreate2/create2collisionStorageParisFiller.json

These tests verify that CREATE/CREATE2 operations fail when targeting an
address with pre-existing storage, per EIP-7610 collision rules.
@LouisTsai-Csie LouisTsai-Csie merged commit 58b4bb0 into ethereum:forks/amsterdam Jan 26, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants