Skip to content

Conversation

@jordalgo
Copy link

@jordalgo jordalgo commented Feb 2, 2026

Make sure to let users know they have to run make test_bin before they run make test. This is on the tests.rst but should be made clear here.

Make sure to let users know they have to run `make test_bin` before they
run `make test`. This is on the tests.rst but should be made clear here.
@jordalgo jordalgo requested a review from qdeslandes as a code owner February 2, 2026 17:49
@meta-cla meta-cla bot added the cla signed label Feb 2, 2026
@qdeslandes qdeslandes merged commit 886214c into facebook:main Feb 2, 2026
29 checks passed
@qdeslandes
Copy link
Contributor

LGTM, thank you!

@jordalgo jordalgo deleted the test_docs branch February 2, 2026 18:07
@pzmarzly
Copy link
Contributor

pzmarzly commented Feb 2, 2026

Could we change the cmake-generated Makefile to reflect this dependency?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants