Fix FieldsBelowInit: Reorder properties in PropsAnimatedNode #55363
+32
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
mdvacca
force-pushed
the
export-D91738282
branch
from
19af00b to
0818b42
Compare
facebook-github-bot
added
the
Shared with Meta
mdvacca
force-pushed
the
export-D91738282
branch
from
0818b42 to
59868b8
Compare
cortinico
approved these changes
Jan 29, 2026
Contributor
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
mdvacca
force-pushed
the
export-D91738282
branch
from
59868b8 to
a63a60d
Compare
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jan 29, 2026
…k#55363) Summary: Fixed FieldsBelowInit lint error in PropsAnimatedNode.kt. Moved `connectedView` computed property above the init block to follow Kotlin initialization order conventions. changelog: [internal] internal Reviewed By: cortinico Differential Revision: D91738282
…k#55360) Summary: Fixed FieldsBelowInit lint errors in ColorAnimatedNode.kt. Moved `color` and `context` computed properties above the init block to follow Kotlin initialization order conventions and prevent potential initialization issues. changelog: [internal] internal Reviewed By: cortinico Differential Revision: D91736974
…ebook#55361) Summary: Fixed FieldsBelowInit lint error in DiffClampAnimatedNode.kt. Moved `inputNodeValue` computed property above the init block to follow Kotlin initialization order conventions. changelog: [internal] internal Reviewed By: cortinico Differential Revision: D91737148
…ger error messages (facebook#55362) Summary: Fixed ReflectionMethodUse lint errors in NativeAnimatedNodesManager.kt. Replaced `::class.java.name` reflection calls with hardcoded class names in error messages to avoid issues with Redex obfuscation in production builds. changelog: [internal] internal Reviewed By: cortinico Differential Revision: D91738126
…k#55363) Summary: Fixed FieldsBelowInit lint error in PropsAnimatedNode.kt. Moved `connectedView` computed property above the init block to follow Kotlin initialization order conventions. changelog: [internal] internal Reviewed By: cortinico Differential Revision: D91738282
mdvacca
force-pushed
the
export-D91738282
branch
from
a63a60d to
740d20c
Compare
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jan 29, 2026
…k#55363) Summary: Fixed FieldsBelowInit lint error in PropsAnimatedNode.kt. Moved `connectedView` computed property above the init block to follow Kotlin initialization order conventions. changelog: [internal] internal Reviewed By: cortinico Differential Revision: D91738282
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jan 29, 2026
…k#55363) Summary: Fixed FieldsBelowInit lint error in PropsAnimatedNode.kt. Moved `connectedView` computed property above the init block to follow Kotlin initialization order conventions. changelog: [internal] internal Reviewed By: cortinico Differential Revision: D91738282
|
This pull request has been merged in f4f9e17. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixed FieldsBelowInit lint error in PropsAnimatedNode.kt.
Moved
connectedViewcomputed property above the init block to followKotlin initialization order conventions.
changelog: [internal] internal
Reviewed By: cortinico
Differential Revision: D91738282