Understand what fails with JDK 21 in OSS #951
Closed
+330
−268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79398167 |
Summary: JDK 21 has changed the expected output of `PointsToSemantics#getClassTest` slightly. Make `PointsToSemantics` test compatible with both JDK 17 and 21. Make the test pass if it meets the expected output of either version, since we can't reliably know the version of JDK from within the test. Differential Revision: D79409803
Summary: JDK 21 compatibility has been fixed in D79409803. Differential Revision: D79398167
xuhdev
force-pushed
the
export-D79398167
branch
from
56e566c to
07c9276
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79398167 |
Contributor
|
This pull request has been merged in f5aa8ad. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D79398167