Promote "Upgrade C++ standard version from 17 to 20" #954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79855023 |
xuhdev
added a commit
to xuhdev/redex
that referenced
this pull request
Aug 8, 2025
Summary:
Promote {D79466725}.
Reviewed By: ssj933
Differential Revision: D79855023
xuhdev
force-pushed
the
export-D79855023-to-stable
branch
from
a9fe9ce to
0afc59c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79855023 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79855023 |
xuhdev
added a commit
to xuhdev/redex
that referenced
this pull request
Aug 8, 2025
Summary: Pull Request resolved: facebook#954 Promote {D79466725}. Reviewed By: ssj933 Differential Revision: D79855023
xuhdev
force-pushed
the
export-D79855023-to-stable
branch
from
0afc59c to
5be395e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79855023 |
xuhdev
added a commit
to xuhdev/redex
that referenced
this pull request
Aug 8, 2025
Summary: Pull Request resolved: facebook#954 Promote {D79466725}. Reviewed By: ssj933 Differential Revision: D79855023
xuhdev
force-pushed
the
export-D79855023-to-stable
branch
from
5be395e to
a59ea87
Compare
Summary: Work around https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116731. Address OSS build error: ``` ../repo/service/cse/CommonSubexpressionElimination.cpp: In member function 'boost::optional<long unsigned int> {anonymous}::Analyzer::get_value_id(const {anonymous}::IRValue&) const': ../repo/service/cse/CommonSubexpressionElimination.cpp:755:23: error: loop variable '<structured bindings>' creates a copy from type 'const std::pair<const DexMethodRef* const, const DexMethodRef*>' [-Werror=range-loop-construct] 755 | for (const auto [box_method, unbox_method] : | ^~~~~~~~~~~~~~~~~~~~~~~~~~ ../repo/service/cse/CommonSubexpressionElimination.cpp:755:23: note: use reference type to prevent copying 755 | for (const auto [box_method, unbox_method] : | ^~~~~~~~~~~~~~~~~~~~~~~~~~ | & ``` Reviewed By: agampe Differential Revision: D79912175
Summary:
Promote {D79466725}.
Reviewed By: ssj933
Differential Revision: D79855023
xuhdev
force-pushed
the
export-D79855023-to-stable
branch
from
a59ea87 to
db09b02
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79855023 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 9, 2025
Summary: Pull Request resolved: #954 Promote {D79466725}. Reviewed By: ssj933 Differential Revision: D79855023 fbshipit-source-id: 6c15f82bcce73a0407df0bbf45880dd8ecf0144c
Member
Author
|
Fixed by 8371d83 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Promote {D79466725}.
Reviewed By: ssj933
Differential Revision: D79855023