Conversation
fix: all required clippy updates
Contributor
Author
This was referenced Jan 7, 2025
Closed
Contributor
Author
|
Looks like the MacOS runners are broken (failure to download parameters). I may disable that as required for now, but if someone wants to take a look at what could get them going again, please do |
Contributor
Marking them as non required is a good idea (I would mark none of the tests as required, in the past it's been causing more issues than good). Once this PR lands, I will retrigger the parameter generation job, which should then make the MacOS ones work again. |
vmx
reviewed
Jan 7, 2025
vmx
reviewed
Jan 9, 2025
vmx
approved these changes
Jan 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a replacement of #1767 (PR moved to this repo)