-
Notifications
You must be signed in to change notification settings - Fork 544
service_section: added parameter for 'storage.max_chunk_size' #2331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Parameter 'storage.max_chunk_size' introduced in the 'input_chunk' module to provide user option to configure maximum size for buffer chunks of input modules. Signed-off-by: Castor Sky <csky57@gmail.com>
📝 WalkthroughWalkthroughDocumentation update to Fluent Bit's storage configuration section: reformats the storage configuration table with improved readability and adds a new Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@administration/configuring-fluent-bit/yaml/service-section.md`:
- Line 38: Remove the invalid table row for `storage.max_chunk_size` (it is not
a Fluent Bit option); either delete that entry from the service-section table or
replace it with the correct setting `storage.max_chunks_up` and document its
meaning (limits the max number of in-memory chunks, default `128`) so the table
reflects valid Fluent Bit configuration options.
eschabell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the one new line added for the new config param, but table structure touched so looks like entire table changed. Looks good.
|
@castorsky thanks for the docs PR, just waiting on the code PR to merge. |
Parameter 'storage.max_chunk_size' introduced in the
input_chunkmodule to provide the user with an option to configure maximum size for buffer chunks of input modules.PR in the
fluent-bitrepo: fluent/fluent-bit#11373Summary by CodeRabbit
storage.max_chunk_sizeconfiguration option (default: 2M) for managing chunk sizes.✏️ Tip: You can customize this high-level summary in your review settings.