testsuite: work around hwloc gpu masking issue #7333
+4
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grondo
approved these changes
Jan 29, 2026
Contributor
grondo
left a comment
grondo
left a comment
There was a problem hiding this comment.
Thanks! Just made a note to remove the previous fix for the same problem on some RSMI systems from the top of the file.
| test_expect_success MULTICORE 'fewer cores: allow-extra allows extra cores' ' | ||
| flux alloc -n1 -o cpu-affinity=off \ | ||
| --conf=resource.verify.core=allow-extra \ | ||
| --conf=resource.verify.gpu=ignore \ |
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7333 +/- ##
==========================================
- Coverage 83.55% 83.53% -0.02%
==========================================
Files 562 562
Lines 93782 93782
==========================================
- Hits 78361 78344 -17
- Misses 15421 15438 +17 🚀 New features to boost your workflow:
|
Problem: on a system with Nvidia GPU and hwloc 2.7.0, some tests in t3218-resource-verify.t are failing. The failing tests are for cores not gpus, so just ignore the gpu counts by setting resource.verify.gpu=ignore. Drop the previous work-around for RSMI systems added in flux-framework#7288 (56dfdd7) and tweaked in flux-framework#7296 that is superseded by this change. Works around flux-framework#7332
Member
Author
|
Thanks - I added that and will set MWP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: on a system with Nvidia GPU and hwloc 2.7.0, some tests in t3218-resource-verify.t are failing.
The failing tests are for cores not gpus, so just ignore the gpu counts by setting resource.verify.gpu=ignore.
Works around #7332