Fix collection copy operation in dataset list#18724
Draft
guerler wants to merge 5 commits intogalaxyproject:devfrom
Draft
Fix collection copy operation in dataset list#18724guerler wants to merge 5 commits intogalaxyproject:devfrom
guerler wants to merge 5 commits intogalaxyproject:devfrom
Conversation
mvdbeek
reviewed
Aug 26, 2024
| } | ||
|
|
||
| async function onCopyDataset(item: HDASummary) { | ||
| async function onCopyContent(item: HDASummary) { |
Member
There was a problem hiding this comment.
The type annotation here isn't correct if you're calling this function onCopyContent
mvdbeek
reviewed
Aug 26, 2024
client/src/api/datasets.ts
Outdated
| export async function copyContent( | ||
| contentId: CopyContentBodyType["content"], | ||
| historyId: CopyContentParamsType["path"]["history_id"], | ||
| type: CopyContentParamsType["path"]["type"] = "dataset" |
Member
There was a problem hiding this comment.
This is ambigous, I would pass in src (at least ldda is another valid dataset type) and then figure out which type it is, or pass both if you want to support dce's as well.
Member
|
Some changes here especially in |
guerler
force-pushed
the
fix_collection_copy
branch
from
50fc1c4 to
8d4bdc4
Compare
guerler
force-pushed
the
fix_collection_copy
branch
from
8d4bdc4 to
a7dd41d
Compare
Contributor
|
This one bit another user recently in #21740 we should definitely fix that 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18658.
How to test the changes?
(Select all options that apply)
License