Skip to content

[25.1] Exclude node_modules at all depths in Docker builds#21721

Merged
mvdbeek merged 1 commit intogalaxyproject:release_25.1from
mvdbeek:exclude_node_modules_from_docker_context
Feb 3, 2026
Merged

[25.1] Exclude node_modules at all depths in Docker builds#21721
mvdbeek merged 1 commit intogalaxyproject:release_25.1from
mvdbeek:exclude_node_modules_from_docker_context

Conversation

@mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Feb 2, 2026

The pattern node_modules only matches at the root level in .dockerignore (unlike .gitignore). Use **/node_modules to exclude client/node_modules and avoid copying 22GB to the build context.

Taken from @dannon's #21593

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

The pattern `node_modules` only matches at the root level in
.dockerignore (unlike .gitignore). Use `**/node_modules` to
exclude client/node_modules and avoid copying 22GB to the
build context.
@github-actions github-actions bot added this to the 26.1 milestone Feb 2, 2026
@mvdbeek mvdbeek merged commit 0128400 into galaxyproject:release_25.1 Feb 3, 2026
41 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants