Add constructive recognition for SL_n

[danielrademacher]

No description provided.

[fingolfin]

Any reason this was changed? It causes CI tests to fail

Suggested change

	ri!.comment := "_PSL2Even";
	ri!.comment := "PSL2Even";

[fingolfin]

Sometimes this still runs into an error:

gap> res:=RECOG.FindStdGensSmallerMatrices_SL(SL(50,5)); time;
Error, List Element: <list>[2] must have an assigned value in
  for ele in eigenspaceGenerators[2] do
    vec := zerovec;
    for j in [ 1 .. Size( ele ) ] do
        vec := vec + ele[j] * result[j];
    od;
    Add( sl2eigenspacebase, vec );
od; at GAPROOT/pkg/recog/gap/projective/constructive_recognition/SL/GoingDown.gi:605 called from
RECOG.Computesl2Subspace( baselist, eigenspacelist
 ) at GAPROOT/pkg/recog/gap/projective/constructive_recognition/SL/GoingDown.gi:545 called from
RECOG.SLn_constructsl2WithSmallerMatrices( sld, d, q
 ) at GAPROOT/pkg/recog/gap/projective/constructive_recognition/SL/main.gi:162 called from
<function "unknown">( <arguments> )
 called from read-eval loop at *stdin*:2
type 'quit;' to quit to outer loop

[fingolfin]

The TestRecogGL tests systematically fail.

[codecov]

Codecov Report

❌ Patch coverage is 40.38633% with 2006 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.70%. Comparing base (72e7a85) to head (29b880d).

Files with missing lines	Patch %	Lines
...projective/constructive_recognition/utils/utils.gi	19.46%	906 Missing ⚠️
...rojective/constructive_recognition/SL/GoingDown.gi	19.65%	376 Missing ⚠️
...ective/constructive_recognition/SL/sl2_BlackBox.gi	8.91%	327 Missing ⚠️
...projective/constructive_recognition/SL/BaseCase.gi	17.62%	243 Missing ⚠️
gap/projective/constructive_recognition/SL/main.gi	40.14%	85 Missing ⚠️
...ojective/constructive_recognition/utils/achieve.gi	90.98%	61 Missing ⚠️
.../projective/constructive_recognition/SL/GoingUp.gi	97.30%	8 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #330      +/-   ##
==========================================
- Coverage   71.55%   65.70%   -5.85%     
==========================================
  Files          43       49       +6     
  Lines       18398    20460    +2062     
==========================================
+ Hits        13164    13443     +279     
- Misses       5234     7017    +1783     

Files with missing lines	Coverage Δ
gap/base/kernel.gi	81.66% <100.00%> (+0.31%)	⬆️
.../projective/constructive_recognition/SL/GoingUp.gi	97.30% <97.30%> (ø)
...ojective/constructive_recognition/utils/achieve.gi	90.98% <90.98%> (ø)
gap/projective/constructive_recognition/SL/main.gi	40.14% <40.14%> (ø)
...projective/constructive_recognition/SL/BaseCase.gi	17.62% <17.62%> (ø)
...ective/constructive_recognition/SL/sl2_BlackBox.gi	8.91% <8.91%> (ø)
...rojective/constructive_recognition/SL/GoingDown.gi	19.65% <19.65%> (ø)
...projective/constructive_recognition/utils/utils.gi	19.46% <19.46%> (ø)

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[fingolfin]

With this PR, RecognizeGroup(GO(+1,4,4)); now runs into an error:

gap> RecognizeGroup(GO(+1,4,4));
Error, hash function not applicable to key of type dense plain list at /Users/mhorn/Projekte/GAP/repos/pkg/gap-packages/orb/gap/hash.gi:131 called from
HT_Hash( ht, x ) at /Users/mhorn/Projekte/GAP/repos/pkg/gap-packages/orb/gap/hash.gi:347 called from
HTValue( o!.ht, o!.op( o!.orbit[j], gens[i] )
 ) at /Users/mhorn/Projekte/GAP/repos/pkg/gap-packages/orb/gap/orbits.gi:1712 called from
func( C[i] ) at /Users/mhorn/Projekte/GAP/gap/lib/coll.gi:663 called from
List( [ 1 .. Length( o!.orbit ) ], function ( j )
      return HTValue( o!.ht, o!.op( o!.orbit[j], gens[i] ) );
  end ) at /Users/mhorn/Projekte/GAP/repos/pkg/gap-packages/orb/gap/orbits.gi:1712 called from
ActionOnOrbit( data.orb, [ el ]
 ) at /Users/mhorn/Projekte/GAP/repos/pkg/gap-packages/orb/gap/orbits.gi:1744 called from
...  at *stdin*:7
you can 'quit;' to quit to outer loop, or
you can 'return;' to continue
brk>