removed solution_formulae and renamed formulas to site_formulae #622
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
SolutionModel().solution_formulaeobject and renamedSolutionModel().formulastoSolutionModel().site_formulae.The
SolutionModel().solution_formulaeobject was originally intended to strip the sites from each site formula in theSolutionModeland return the chemical formulae, e.g.:[Mg]3[Mg0.5Si0.5]2Si3O12 -> Mg4Si4O12This intended use is essentially a duplication of the
Solution().endmember_formulaeobject, which is itself derived fromSolutionModel().endmembers. So the intended functionality is provided by another object.Since writing the function, solution models have been generalised to the point that
SolutionModel().solution_formulaemight look quite different fromSolution().endmember_formulae, but would not be as readable or contain any information that is not already inSolutionModel().formulas(nowSolutionModel().site_formulae). For example:Mg3Fef2Si3O12is no more useful than[Mg]3[Fef]2Si3O12.