Avoid late-init crashes in LanternFFIService when Windows IPC is unavailable #8431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes the Windows IPC service optional in LanternFFIService to prevent late-initialization crashes when Windows IPC is unavailable (e.g., missing token, timeout). The service now falls back to safe defaults and non-IPC code paths when Windows IPC initialization fails.
Changes:
- Made
_windowsServicenullable and added null safety checks before all Windows IPC operations - Provided default fallback streams for status, private server status, and app events
- Added graceful error handling that allows initialization to continue when Windows IPC fails
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/getlantern/engineering/issues/2936