fix(binding): add explicit interface types in binding_nomsgpack.go
#4478
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds explicit interface types to variable declarations in
binding_nomsgpack.goto allow third-party libraries to reassign bindings with custom implementations.binding.gohas explicit interface types.Related Issue
Without explicit interface types, variables like
binding.JSONare typed as their concrete struct (e.g.,jsonBinding) rather than theBindingBodyinterface. This prevents libraries from reassigning these variables with wrapper types that implement the same interface. Source.This allows to fix DataDog/dd-trace-go#4114 where the missing explicit types prevent compilation when using the
nomsgpackbuild tag.Pull Request Checklist
Please ensure your pull request meets the following requirements:
masterbranch.docs/doc.md.Thank you for contributing!