Merged
Conversation
Without this change, the debug macro may pick up a local variable in the method instead of the member variable it is supposed to reference. Found when adding ptz_debug statements to the PTZViscaOverIp::receive_datagram method Signed-off-by: Grant Likely <[email protected]>
If the host field is an IP address, then the call to lookupHost() will delay for some time while it tries to do a reverse hostname lookup. This isn't what is wanted, and lookupHost() doesn't need to be called to parse an IP address field. Fix this by trying first to parse the host field as an IP address, and only call lookupHost() if that fails (which it will if the host field contains a hostname. Signed-off-by: Grant Likely <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix long delay before VISCA UDP devices start working because the code was waiting on a reverse hostname lookup that wasn't needed.