feat(gnoweb): Add Source and Action button for realm explorer by Davphla · Pull Request #5032 · gnolang/gno

Davphla · 2026-01-07T20:09:47Z

close: #5028

Gno2D2 · 2026-01-07T20:10:21Z

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):

IGNORE the bot requirements for this PR (force green CI check)
The pull request description provides enough details

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)
🟢 Changes related to gnoweb must be reviewed by its codeowners
🟢 Pending initial approval by a review team member, or review from tech-staff

☑️ Contributor Actions:

Fix any issues flagged by automated checks.
Follow the Contributor Checklist to ensure your PR is ready for review.
- Add new tests, or document why they are unnecessary.
- Provide clear examples/screenshots, if necessary.
- Update documentation, if required.
- Ensure no breaking changes, or include BREAKING CHANGE notes.
- Link related issues/PRs, where applicable.

☑️ Reviewer Actions:

Complete manual checks for the PR, including the guidelines and additional checks if applicable.

📚 Resources:

Debug

Automated Checks

Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: Davphla/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Changes related to gnoweb must be reviewed by its codeowners

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 A changed file matches this pattern: ^gno.land/pkg/gnoweb/ (filename: gno.land/pkg/gnoweb/components/view_directory.go)

Then

🟢 Requirement satisfied
└── 🟢 Or
    ├── 🔴 Or
    │   ├── 🔴 And
    │   │   ├── 🔴 Pull request author is user: alexiscolin
    │   │   └── 🟢 This user reviewed pull request: gfanton (with state "APPROVED")
    │   └── 🔴 And
    │       ├── 🔴 Pull request author is user: gfanton
    │       └── 🔴 This user reviewed pull request: alexiscolin (with state "APPROVED")
    └── 🟢 And
        ├── 🟢 Not (🔴 Pull request author is user: alexiscolin)
        ├── 🟢 Not (🔴 Pull request author is user: gfanton)
        └── 🟢 Or
            ├── 🔴 This user reviewed pull request: alexiscolin (with state "APPROVED")
            └── 🟢 This user reviewed pull request: gfanton (with state "APPROVED")

Pending initial approval by a review team member, or review from tech-staff

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 Not (🔴 Pull request author is a member of the team: tech-staff)

Then

🟢 Requirement satisfied
└── 🟢 If
    ├── 🟢 Condition
    │   └── 🟢 Or
    │       ├── 🟢 User MikaelVallenet already reviewed PR 5032 with state APPROVED
    │       ├── 🟢 At least 1 user(s) of the team tech-staff reviewed pull request
    │       └── 🔴 This pull request is a draft
    └── 🟢 Then
        └── 🟢 Not (🔴 This label is applied to pull request: review/triage-pending)

Manual Checks

**IGNORE** the bot requirements for this PR (force green CI check)
If
🟢 Condition met
└── 🟢 On every pull request
Can be checked by

Any user with comment edit permission
The pull request description provides enough details
If
🟢 Condition met
└── 🟢 And
    ├── 🟢 Not (🔴 Pull request author is a member of the team: core-contributors)
    └── 🟢 Not (🔴 Pull request author is user: dependabot[bot])
Can be checked by

team core-contributors

codecov · 2026-01-07T20:35:26Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

…od behavior

MikaelVallenet

You should add more

MikaelVallenet · 2026-01-12T12:48:44Z

gno.land/pkg/gnoweb/handler_http.go

+		}
+
+		// Query the package documentation
+		jdoc, err := h.Client.Doc(ctx, pkgPath)


should we find a way to batch this query ?

Fix: 09cc22e

MikaelVallenet · 2026-01-12T12:56:37Z

gno.land/pkg/gnoweb/client_test.go

+	"github.com/stretchr/testify/assert"
+)
+
+func TestHasRenderFunction(t *testing.T) {


would be nice to add more test (wrong number of param, wrong param type, ...)

Fix: 8b3dcb0

moonia

lgtm

gfanton

I like the source + action buttons, but the BatchDoc just for looking for a Render function seems inefficient; this will probably add latency to directory listing, especially . It would be more efficient to have this at the keeper level, but I'm not sure we want this to exist.
It would probably fine for a few realm, but right now directory listing can show hundred of package.

gfanton · 2026-01-21T09:53:19Z

gno.land/pkg/gnoweb/client.go

+	if err := ctx.Err(); err != nil {
+		return nil, fmt.Errorf("%w: %s", ErrClientTimeout, err.Error())
+	}


Remove this; it is not necessary at this point, as there is no blocking state.

…handling

Davphla · 2026-01-23T16:46:35Z

@gfanton I simplified the PR. I remove the render icon feature, and clean duplicate / non-clean code. We can create another PR back later for this feature, as it is very costly for the little addition.
The only real change is in directory.html.

gfanton

looks good

feat(gnoweb): Add Source and Action button for realm explorer

e41b5cc

github-project-automation bot added this to 🧙‍♂️Gno.land development and 💪 Bounties & Worx Jan 7, 2026

github-project-automation bot moved this to Triage in 🧙‍♂️Gno.land development Jan 7, 2026

github-actions bot assigned Davphla Jan 7, 2026

github-actions bot added 📦 ⛰️ gno.land Issues or PRs gno.land package related 🌍 gnoweb Issues & PRs related to gnoweb and render labels Jan 7, 2026

Gno2D2 requested review from alexiscolin and gfanton January 7, 2026 20:10

Gno2D2 added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Jan 7, 2026

docs(gnoweb): update comment for FullFileLink

c99d4a3

Davphla added this to FlashorgSprint: Gnocore Minicrew 🥷 Jan 7, 2026

Davphla moved this to NEED PEER REVIEW (INTERNAL) in FlashorgSprint: Gnocore Minicrew 🥷 Jan 7, 2026

Davphla removed this from FlashorgSprint: Gnocore Minicrew 🥷 Jan 7, 2026

Davphla added 3 commits January 7, 2026 22:25

feat(gnoweb): add tests for Post method handling in HTTP handler

f0abe99

feat(gnoweb): add tests for HTTP handler error handling and POST meth…

c0df1f1

…od behavior

refactor(tests): simplify tests

103a02d

MikaelVallenet reviewed Jan 12, 2026

View reviewed changes

Davphla and others added 3 commits January 12, 2026 16:18

Merge branch 'master' into david/gnoweb/new-button

2f88a4d

tests: remove unrelated tests

ad975aa

test(gnoweb): enhance TestHasRenderFunction with additional cases

8b3dcb0

notJoon approved these changes Jan 13, 2026

View reviewed changes

Gno2D2 removed the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Jan 13, 2026

Davphla added 2 commits January 13, 2026 16:17

feat(gnoweb): add batch for doc query

09cc22e

feat(gnoweb): add hasRenderMap in parameter of DirectoryView

6dbe87c

Davphla requested a review from MikaelVallenet January 13, 2026 16:35

Davphla added 2 commits January 13, 2026 17:38

Merge branch 'master' into david/gnoweb/new-button

0a51b45

Merge branch 'master' into david/gnoweb/new-button

e2632b4

chore(gnoweb): regenerate css

413b9c5

MikaelVallenet requested a review from moonia January 14, 2026 16:51

MikaelVallenet approved these changes Jan 14, 2026

View reviewed changes

moonia approved these changes Jan 14, 2026

View reviewed changes

Merge branch 'master' into david/gnoweb/new-button

e3116a4

gfanton reviewed Jan 21, 2026

View reviewed changes

Davphla added 4 commits January 23, 2026 16:27

refactor(gnoweb): remove DocBatch method and related render metadata …

125aa33

…handling

fix: remove sourcelink variable and hugely simplify the feature

5dbd80f

chore: remove obsolete code and generate css

59907db

fix: dupplicate test

14cb226

Davphla requested a review from gfanton January 23, 2026 16:46

gfanton approved these changes Jan 27, 2026

View reviewed changes

Merge branch 'master' into david/gnoweb/new-button

f675e22

Conversation

Davphla commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Gno2D2 commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🛠 PR Checks Summary

Manual Checks (for Reviewers):

✅ Automated Checks (for Contributors):

☑️ Contributor Actions:

☑️ Reviewer Actions:

📚 Resources:

If

Then

If

Then

If

Then

If

Can be checked by

If

Can be checked by

Uh oh!

codecov bot commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

MikaelVallenet left a comment

Choose a reason for hiding this comment

Uh oh!

MikaelVallenet Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Davphla Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

MikaelVallenet Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Davphla Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

moonia left a comment

Choose a reason for hiding this comment

Uh oh!

gfanton left a comment

Choose a reason for hiding this comment

Uh oh!

gfanton Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Davphla commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gfanton left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Davphla commented Jan 7, 2026 •

edited

Loading

Gno2D2 commented Jan 7, 2026 •

edited

Loading

codecov bot commented Jan 7, 2026 •

edited

Loading

Davphla commented Jan 23, 2026 •

edited

Loading